83855b7 Merge pull request #5362 from open-webui/dev
d4df552 Merge pull request #5537 from open-webui/dev
e1ea0c2 Fixed the issue of being unable to generate titles
📊 Changes
1 file changed (+8 additions, -3 deletions)
View changed files
📝backend/open_webui/apps/openai/main.py (+8 -3)
📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
This pull request addresses and resolves the issue where users were unable to generate titles. The fix improves the reliability and functionality of the title generation feature.
Added
N/A
Changed
The O1 model and previous regular GPT models have different keys for the maximum token count limit.
For the O1 model, it has been changed to max_completion_tokens.
The original code incorrectly passes new parameters, causing errors in the old model. Such as Unrecognized request argument supplied: max_completion_tokens
Deprecated
N/A
Removed
N/A
Fixed
Modified the input parameters for initiating requests
Security
N/A
Breaking Changes
N/A
Additional Information
N/A
Screenshots or Videos
Before repair
After repair
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/5541
**Author:** [@kivvi3412](https://github.com/kivvi3412)
**Created:** 9/20/2024
**Status:** ✅ Merged
**Merged:** 9/21/2024
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `fix-title-generate`
---
### 📝 Commits (3)
- [`83855b7`](https://github.com/open-webui/open-webui/commit/83855b713b0f211144993486ac5265d3d67bb1f8) Merge pull request #5362 from open-webui/dev
- [`d4df552`](https://github.com/open-webui/open-webui/commit/d4df55207696ded0c32dd41d87e809beea591be4) Merge pull request #5537 from open-webui/dev
- [`e1ea0c2`](https://github.com/open-webui/open-webui/commit/e1ea0c23ebb4a5d35b9406d21bc4fe747c344705) Fixed the issue of being unable to generate titles
### 📊 Changes
**1 file changed** (+8 additions, -3 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/apps/openai/main.py` (+8 -3)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [x] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
- This pull request addresses and resolves the issue where users were unable to generate titles. The fix improves the reliability and functionality of the title generation feature.
### Added
N/A
### Changed
- The O1 model and previous regular GPT models have different keys for the maximum token count limit.
- For the O1 model, it has been changed to `max_completion_tokens`.
- The original code incorrectly passes new parameters, causing errors in the old model. Such as `Unrecognized request argument supplied: max_completion_tokens`
### Deprecated
N/A
### Removed
N/A
### Fixed
- Modified the input parameters for initiating requests
### Security
N/A
### Breaking Changes
N/A
---
### Additional Information
N/A
### Screenshots or Videos
- Before repair
<img width="929" alt="iShot_2024-09-20_15 35 01" src="https://github.com/user-attachments/assets/372884ed-077c-47d8-bee2-c729f2bd6194">
- After repair
<img width="765" alt="image" src="https://github.com/user-attachments/assets/11dde0cd-6c1f-49a3-a7a1-90b181ef7c0f">
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/5541
Author: @kivvi3412
Created: 9/20/2024
Status: ✅ Merged
Merged: 9/21/2024
Merged by: @tjbck
Base:
dev← Head:fix-title-generate📝 Commits (3)
83855b7Merge pull request #5362 from open-webui/devd4df552Merge pull request #5537 from open-webui/deve1ea0c2Fixed the issue of being unable to generate titles📊 Changes
1 file changed (+8 additions, -3 deletions)
View changed files
📝
backend/open_webui/apps/openai/main.py(+8 -3)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Added
N/A
Changed
max_completion_tokens.Unrecognized request argument supplied: max_completion_tokensDeprecated
N/A
Removed
N/A
Fixed
Security
N/A
Breaking Changes
N/A
Additional Information
N/A
Screenshots or Videos
Before repair
After repair
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.