[PR #5270] [MERGED] fix: socket.io connections failing when websockets are not available #92695

New Issue

GiteaMirror · 2026-05-15T18:19:39-05:00

GiteaMirror commented

2026-05-15 18:19:39 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/5270
Author: @cheahjs
Created: 9/8/2024
Status: ✅ Merged
Merged: 9/9/2024
Merged by: @tjbck

Base: dev ← Head: fix/websocket-take-2

📝 Commits (3)

698976a feat: add ENABLE_WEBSOCKET_SUPPORT to force socket.io to ignore websocket upgrades
827c419 feat: add ENABLE_WEBSOCKET_SUPPORT to force socket.io to ignore websocket upgrades
9401f6c fix: workaround socketio upstream bug when websockets are not available

📊 Changes

4 files changed (+33 additions, -11 deletions)

View changed files

📝 backend/open_webui/apps/socket/main.py (+8 -1)
📝 backend/open_webui/env.py (+4 -0)
📝 backend/open_webui/main.py (+18 -0)
📝 src/routes/+layout.svelte (+3 -10)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Add an explicit ENABLE_WEBSOCKET_SUPPORT environment variable for environments where websockets are not available.
Drop invalid socket.io websocket upgrades before they hit python-socketio because of https://github.com/miguelgrinberg/python-engineio/issues/367
This removes the frontend's explicit selection of transports introduced in https://github.com/open-webui/open-webui/pull/5076 and defaults back to standard upgrade behaviour, since that introduced its own set of bugs (see Discord thread)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/5270 **Author:** [@cheahjs](https://github.com/cheahjs) **Created:** 9/8/2024 **Status:** ✅ Merged **Merged:** 9/9/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/websocket-take-2` --- ### 📝 Commits (3) - [`698976a`](https://github.com/open-webui/open-webui/commit/698976add087cc6b4976d6333efa9d2383c39f22) feat: add ENABLE_WEBSOCKET_SUPPORT to force socket.io to ignore websocket upgrades - [`827c419`](https://github.com/open-webui/open-webui/commit/827c41925137570599e876435ca2f65b3a6007b2) feat: add ENABLE_WEBSOCKET_SUPPORT to force socket.io to ignore websocket upgrades - [`9401f6c`](https://github.com/open-webui/open-webui/commit/9401f6c8217821489d7950d0c27e3a94d46591e3) fix: workaround socketio upstream bug when websockets are not available ### 📊 Changes **4 files changed** (+33 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/apps/socket/main.py` (+8 -1) 📝 `backend/open_webui/env.py` (+4 -0) 📝 `backend/open_webui/main.py` (+18 -0) 📝 `src/routes/+layout.svelte` (+3 -10) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Add an explicit `ENABLE_WEBSOCKET_SUPPORT` environment variable for environments where websockets are not available. - Drop invalid socket.io websocket upgrades before they hit `python-socketio` because of https://github.com/miguelgrinberg/python-engineio/issues/367 - This removes the frontend's explicit selection of transports introduced in https://github.com/open-webui/open-webui/pull/5076 and defaults back to standard upgrade behaviour, since that introduced its own set of bugs (see [Discord thread](https://discord.com/channels/1170866489302188073/1282065441916719156)) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-15 18:19:39 -05:00

GiteaMirror closed this issue

2026-05-15 18:19:41 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#92695