[PR #9142] [MERGED] feat: delete unused response message from other "branches" #9120

Closed
opened 2025-11-11 18:14:38 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/9142
Author: @dannyl1u
Created: 1/31/2025
Status: Merged
Merged: 1/31/2025
Merged by: @tjbck

Base: devHead: feat/delete-unused-response-message


📝 Commits (1)

  • e9f05b6 feat: delete message responses

📊 Changes

2 files changed (+36 additions, -0 deletions)

View changed files

📝 src/lib/components/chat/Messages/Message.svelte (+1 -0)
📝 src/lib/components/chat/Messages/ResponseMessage.svelte (+35 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Closes #8928

Added

  • Ability to delete a response message from the conversation if there are multiple responses and it is the last response message

Changed

  • The deleted response(s) are no longer included in the context payload of further API calls

Deprecated

  • N/A

Removed

  • N/A

Fixed

  • N/A

Security

  • N/A

Breaking Changes

  • N/A

Additional Information

  • Reused existing delete message icons from UserMessage.svelte
  • reuses same delete message function tested by test_delete_chat_by_id, please let me know if any further tests are needed

Screenshots or Videos

https://github-production-user-asset-6210df.s3.amazonaws.com/45186464/408409874-a999be8a-da9d-4f41-a7d8-9209c95f29f6.mov?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20250131%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20250131T050544Z&X-Amz-Expires=300&X-Amz-Signature=f7273bd1118dd70a51edd514f41fd614f67cfebc5d100adf689c63b20c72854e&X-Amz-SignedHeaders=host


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/9142 **Author:** [@dannyl1u](https://github.com/dannyl1u) **Created:** 1/31/2025 **Status:** ✅ Merged **Merged:** 1/31/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `feat/delete-unused-response-message` --- ### 📝 Commits (1) - [`e9f05b6`](https://github.com/open-webui/open-webui/commit/e9f05b6cd76a53523ac98b60352e7a732b305db8) feat: delete message responses ### 📊 Changes **2 files changed** (+36 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/Message.svelte` (+1 -0) 📝 `src/lib/components/chat/Messages/ResponseMessage.svelte` (+35 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Closes #8928 ### Added - Ability to delete a response message from the conversation if there are multiple responses **and** it is the last response message ### Changed - The deleted response(s) are no longer included in the context payload of further API calls ### Deprecated - N/A ### Removed - N/A ### Fixed - N/A ### Security - N/A ### Breaking Changes - N/A --- ### Additional Information - Reused existing delete message icons from `UserMessage.svelte` - reuses same `delete` message function tested by `test_delete_chat_by_id`, please let me know if any further tests are needed ### Screenshots or Videos https://github-production-user-asset-6210df.s3.amazonaws.com/45186464/408409874-a999be8a-da9d-4f41-a7d8-9209c95f29f6.mov?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20250131%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20250131T050544Z&X-Amz-Expires=300&X-Amz-Signature=f7273bd1118dd70a51edd514f41fd614f67cfebc5d100adf689c63b20c72854e&X-Amz-SignedHeaders=host --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:14:38 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#9120