[PR #9131] [MERGED] fix: Add error catching for function pip install issues #9119

Closed
opened 2025-11-11 18:14:37 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/9131
Author: @westbrook-ai
Created: 1/30/2025
Status: Merged
Merged: 1/30/2025
Merged by: @tjbck

Base: devHead: dev


📝 Commits (2)

  • 48c2fb0 fix: Add error catching for function pip install issues
  • 124fdcc Merge branch 'open-webui:dev' into dev

📊 Changes

1 file changed (+9 additions, -4 deletions)

View changed files

📝 backend/open_webui/utils/plugin.py (+9 -4)

📄 Description

Pull Request Checklist

  • [ x ] Target branch: Please verify that the pull request targets the dev branch.
  • [ x ] Description: Provide a concise description of the changes made in this pull request.
  • [ x ] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • [ N/A ] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • [ N/A ] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • [ N/A ] Testing: Have you written and run sufficient tests for validating the changes?
  • [ x ] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • [ x ] Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • fix: Bug fix or error correction

Changelog Entry

Description

Adds error catching and logging to the install_frontmatter_requirements function in utils/plugin.py.

Fixed

  • Added error checking to utils/plugin.py

Additional Information

I am running into errors like such on my Open WebUI deployment:

"GET /api/models HTTP/1.1" 200 OK
"GET /api/v1/functions/id/datadog_llm_observability_filter HTTP/1.1" 200 OK
 "POST /api/v1/utils/code/format HTTP/1.1"
INFO  [open_webui.utils.plugin] Installing requirement: ddtrace
…Pip installs succeed…
INFO  [open_webui.utils.plugin] Loaded module: function_datadog_llm_observability_filter
INFO:     Shutting down
INFO:     connection closed
INFO:     <IP>:0 - "POST /api/v1/functions/id/datadog_llm_observability_filter/update HTTP/1.1" 200 OK
INFO:     Waiting for application shutdown.
INFO:     Application shutdown complete.
INFO:     Finished server process [1]

The goal of this PR is to attempt to catch any failures in function requirements downloads to prevent crashes, and to get a log when issues occur on this step so they can be investigated further.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/9131 **Author:** [@westbrook-ai](https://github.com/westbrook-ai) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 1/30/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (2) - [`48c2fb0`](https://github.com/open-webui/open-webui/commit/48c2fb0d24e50fc390efc291e13ace5d3a04de2c) fix: Add error catching for function pip install issues - [`124fdcc`](https://github.com/open-webui/open-webui/commit/124fdcc48c36359659ac0c712174203d6a0875e7) Merge branch 'open-webui:dev' into dev ### 📊 Changes **1 file changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/plugin.py` (+9 -4) </details> ### 📄 Description # Pull Request Checklist - [ x ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ x ] **Description:** Provide a concise description of the changes made in this pull request. - [ x ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ N/A ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ N/A ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ N/A ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ x ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ x ] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **fix**: Bug fix or error correction # Changelog Entry ### Description Adds error catching and logging to the `install_frontmatter_requirements` function in `utils/plugin.py`. ### Fixed - Added error checking to `utils/plugin.py` ### Additional Information I am running into errors like such on my Open WebUI deployment: ``` "GET /api/models HTTP/1.1" 200 OK "GET /api/v1/functions/id/datadog_llm_observability_filter HTTP/1.1" 200 OK "POST /api/v1/utils/code/format HTTP/1.1" INFO [open_webui.utils.plugin] Installing requirement: ddtrace …Pip installs succeed… INFO [open_webui.utils.plugin] Loaded module: function_datadog_llm_observability_filter INFO: Shutting down INFO: connection closed INFO: <IP>:0 - "POST /api/v1/functions/id/datadog_llm_observability_filter/update HTTP/1.1" 200 OK INFO: Waiting for application shutdown. INFO: Application shutdown complete. INFO: Finished server process [1] ``` The goal of this PR is to attempt to catch any failures in function requirements downloads to prevent crashes, and to get a log when issues occur on this step so they can be investigated further. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:14:37 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#9119