[PR #13] [MERGED] chore: add fmt to github actions #91143

New Issue

GiteaMirror · 2026-05-15T16:28:08-05:00

GiteaMirror commented

2026-05-15 16:28:08 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13
Author: @coolaj86
Created: 10/22/2023
Status: ✅ Merged
Merged: 10/22/2023
Merged by: @tjbck

Base: main ← Head: chore-fmt

📝 Commits (3)

2eea764 fix: contants => constants
d188512 chore: npm run fmt
ee63832 chore: check PRs for fmt, lint, & build

📊 Changes

8 files changed (+95 additions, -66 deletions)

View changed files

➕ .github/workflows/node.js.yaml (+25 -0)
📝 package.json (+6 -2)
📝 postcss.config.js (+5 -5)
📝 src/lib/components/common/Overlay.svelte (+33 -33)
📝 src/lib/components/common/Spinner.svelte (+24 -24)
📝 src/lib/constants.ts (+0 -0)
📝 src/routes/+page.server.ts (+1 -1)
📝 src/routes/+page.svelte (+1 -1)

📄 Description

I noticed that the other PR had whitespace changes in it, which probably came from my editor being incorrect, or a mismatch of prettier@3 on your local machine and prettier@2 in the repo.

I didn't update this to prettier@3 because it's pretty new (less than 3 months, I think) I don't know if v3 is compatible with all the svelte plugins.

Anyway, you can set it such that PRs need to pass lint and fmt before they can be rebased into main.

[x] Require status checks to pass before merging

I was going to add the lint and type checking as well, but there many type and lint errors that would need to be fixed first.

https://github.com/ollama-webui/ollama-webui/branch_protection_rules/

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13 **Author:** [@coolaj86](https://github.com/coolaj86) **Created:** 10/22/2023 **Status:** ✅ Merged **Merged:** 10/22/2023 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `main` ← **Head:** `chore-fmt` --- ### 📝 Commits (3) - [`2eea764`](https://github.com/open-webui/open-webui/commit/2eea76437898151380e2ba016663c4405169ce65) fix: contants => constants - [`d188512`](https://github.com/open-webui/open-webui/commit/d1885122632869cf81a61639b3cbf3a0e9953631) chore: npm run fmt - [`ee63832`](https://github.com/open-webui/open-webui/commit/ee638329f13a86cad94124fc354a0c33f02f190c) chore: check PRs for fmt, lint, & build ### 📊 Changes **8 files changed** (+95 additions, -66 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/node.js.yaml` (+25 -0) 📝 `package.json` (+6 -2) 📝 `postcss.config.js` (+5 -5) 📝 `src/lib/components/common/Overlay.svelte` (+33 -33) 📝 `src/lib/components/common/Spinner.svelte` (+24 -24) 📝 `src/lib/constants.ts` (+0 -0) 📝 `src/routes/+page.server.ts` (+1 -1) 📝 `src/routes/+page.svelte` (+1 -1) </details> ### 📄 Description I noticed that the other PR had whitespace changes in it, which probably came from my editor being incorrect, or a mismatch of `prettier@3` on your local machine and `prettier@2` in the repo. I didn't update this to `prettier@3` because it's pretty new (less than 3 months, I think) I don't know if v3 is compatible with all the svelte plugins. Anyway, you can set it such that PRs need to pass lint and fmt before they can be rebased into main. > [x] Require status checks to pass before merging I was going to add the lint and type checking as well, but there many type and lint errors that would need to be fixed first. https://github.com/ollama-webui/ollama-webui/branch_protection_rules/ <img width="1192" alt="Screenshot 2023-10-21 at 10 39 01 PM" src="https://github.com/ollama-webui/ollama-webui/assets/122831/17846183-0461-4763-9d4c-0763af7bbacc"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-15 16:28:08 -05:00

GiteaMirror closed this issue

2026-05-15 16:28:10 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#91143