Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
None
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
feat: Introduces a new feature or enhancement to the codebase
Changelog Entry
Description
Adding the ability for users who create private models/knowledge/prompts/tools in the workspace to also choose which groups can modify the created model/knowledge/prompt/tool. The user can only choose between groups they are already in. This change allows users to allow others to edit their custom data, while still maintaining the read-only aspects by default.
Added
Adding the ability for users who create private models/knowledge/prompts/tools in the workspace to also choose which groups can modify the created model/knowledge/prompt/tool.
Screenshots or Videos
Walk-through example:
Users t2 and t3 are in the group "multi-edit-test" together, with all workspace permissions:
User t3 decides to create a knowledge(can also be a model, prompt or tool) and share it to the group "multi-edit-test", with only read access (the default):
User t2 cannot see the knowledge but can use it when making a model:
User t3 decides to make the knowledge writeable by the group by clicking the "read" badge:
User t2 can now see the knowledge in the workspace and edit it, as well as use it in models:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/8470
**Author:** [@tarmst](https://github.com/tarmst)
**Created:** 1/10/2025
**Status:** ✅ Merged
**Merged:** 1/14/2025
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `add-read-write-toggle-to-access-control`
---
### 📝 Commits (1)
- [`49eca68`](https://github.com/open-webui/open-webui/commit/49eca68e28f373b602ab1746b7b79f8bfad45ce4) Add toggle to read/write perms on access control
### 📊 Changes
**5 files changed** (+39 additions, -7 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/routers/knowledge.py` (+2 -2)
📝 `backend/open_webui/routers/prompts.py` (+3 -2)
📝 `backend/open_webui/routers/tools.py` (+2 -1)
📝 `src/lib/components/workspace/Models.svelte` (+7 -1)
📝 `src/lib/components/workspace/common/AccessControl.svelte` (+25 -1)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
Associated but slightly different discussion post: https://github.com/open-webui/open-webui/discussions/8373
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- None
- [x] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **feat**: Introduces a new feature or enhancement to the codebase
# Changelog Entry
### Description
Adding the ability for users who create private models/knowledge/prompts/tools in the workspace to also choose which groups can modify the created model/knowledge/prompt/tool. The user can only choose between groups they are already in. This change allows users to allow others to edit their custom data, while still maintaining the read-only aspects by default.
### Added
Adding the ability for users who create private models/knowledge/prompts/tools in the workspace to also choose which groups can modify the created model/knowledge/prompt/tool.
---
### Screenshots or Videos
Walk-through example:
Users t2 and t3 are in the group "multi-edit-test" together, with all workspace permissions:
<img width="667" alt="Screenshot 2025-01-10 at 1 52 54 PM" src="https://github.com/user-attachments/assets/9dd106c0-6a18-4aa8-9700-cdf1fd19aab4" />
User t3 decides to create a knowledge(can also be a model, prompt or tool) and share it to the group "multi-edit-test", with only read access (the default):
<img width="556" alt="Screenshot 2025-01-10 at 2 01 27 PM" src="https://github.com/user-attachments/assets/a654fc50-ba1c-49e6-8ff5-011dc97982d7" />
User t2 cannot see the knowledge but can use it when making a model:
<img width="592" alt="Screenshot 2025-01-10 at 2 02 01 PM" src="https://github.com/user-attachments/assets/e76afb10-5b2b-46af-aabd-9a274b8efec9" />
<img width="757" alt="Screenshot 2025-01-10 at 2 04 30 PM" src="https://github.com/user-attachments/assets/e8c05dd7-d6f8-4964-8f37-bd04db13a7ab" />
User t3 decides to make the knowledge writeable by the group by clicking the "read" badge:
<img width="476" alt="Screenshot 2025-01-10 at 2 05 19 PM" src="https://github.com/user-attachments/assets/b497ea3f-b7b2-4b0a-bac3-71aa7810e197" />
User t2 can now see the knowledge in the workspace and edit it, as well as use it in models:
<img width="542" alt="Screenshot 2025-01-10 at 2 06 16 PM" src="https://github.com/user-attachments/assets/9c1a5d70-f4ab-4add-8899-70d5a5c4791f" />
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/8470
Author: @tarmst
Created: 1/10/2025
Status: ✅ Merged
Merged: 1/14/2025
Merged by: @tjbck
Base:
dev← Head:add-read-write-toggle-to-access-control📝 Commits (1)
49eca68Add toggle to read/write perms on access control📊 Changes
5 files changed (+39 additions, -7 deletions)
View changed files
📝
backend/open_webui/routers/knowledge.py(+2 -2)📝
backend/open_webui/routers/prompts.py(+3 -2)📝
backend/open_webui/routers/tools.py(+2 -1)📝
src/lib/components/workspace/Models.svelte(+7 -1)📝
src/lib/components/workspace/common/AccessControl.svelte(+25 -1)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Associated but slightly different discussion post: https://github.com/open-webui/open-webui/discussions/8373
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the
devbranch.Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
Changelog Entry
Description
Adding the ability for users who create private models/knowledge/prompts/tools in the workspace to also choose which groups can modify the created model/knowledge/prompt/tool. The user can only choose between groups they are already in. This change allows users to allow others to edit their custom data, while still maintaining the read-only aspects by default.
Added
Adding the ability for users who create private models/knowledge/prompts/tools in the workspace to also choose which groups can modify the created model/knowledge/prompt/tool.
Screenshots or Videos
Walk-through example:
Users t2 and t3 are in the group "multi-edit-test" together, with all workspace permissions:
User t3 decides to create a knowledge(can also be a model, prompt or tool) and share it to the group "multi-edit-test", with only read access (the default):
User t2 cannot see the knowledge but can use it when making a model:
User t3 decides to make the knowledge writeable by the group by clicking the "read" badge:
User t2 can now see the knowledge in the workspace and edit it, as well as use it in models:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.