[PR #8376] [MERGED] perf: use ldap3.NONE for parameter get_info in ldap_auth function to accelerate login #9007

New Issue

GiteaMirror · 2025-11-11T18:11:41-06:00

GiteaMirror commented

2025-11-11 18:11:41 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/8376
Author: @steelcg
Created: 1/7/2025
Status: ✅ Merged
Merged: 1/8/2025
Merged by: @tjbck

Base: dev ← Head: dev

📝 Commits (1)

82ff6c3 use ldap3.NONE for parameter get_info in ldap_auth function to accelerate login

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 backend/open_webui/routers/auths.py (+2 -2)

📄 Description

see: #8204

The project is a wonderful project and helps a lot.

We have deployed it in our internal network. But after our test, there is a little problem which bothering us that it takes more than 8 seconds to login in our environment.

Describe the solution you'd like

I searched related information and found there should be a solution. We can replace a value of parameter from "ALL" to "ldap3.NONE" to solve.

Refer to (https://github.com/cannatag/ldap3/issues/534, use NONE will obviously accelerate LDAP search.

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

improving performance for LDAP login

Changed

improving performance for LDAP login

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/8376 **Author:** [@steelcg](https://github.com/steelcg) **Created:** 1/7/2025 **Status:** ✅ Merged **Merged:** 1/8/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`82ff6c3`](https://github.com/open-webui/open-webui/commit/82ff6c371b88a4dcda85a000a4bd2dfbbc912789) use ldap3.NONE for parameter get_info in ldap_auth function to accelerate login ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/auths.py` (+2 -2) </details> ### 📄 Description see: #8204 The project is a wonderful project and helps a lot. We have deployed it in our internal network. But after our test, there is a little problem which bothering us that it takes more than 8 seconds to login in our environment. Describe the solution you'd like I searched related information and found there should be a solution. We can replace a value of parameter from "ALL" to "ldap3.NONE" to solve. Refer to [(https://github.com/cannatag/ldap3/issues/534](https://github.com/cannatag/ldap3/issues/534), use NONE will obviously accelerate LDAP search. # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - improving performance for LDAP login ### Changed - improving performance for LDAP login --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 18:11:41 -06:00

GiteaMirror closed this issue

2025-11-11 18:11:42 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#9007