Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
No dependencies
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
feat: Introduces a new feature or enhancement to the codebase
Changelog Entry
Description
[Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)]
Added additional permissions for groups in the workspace to prevent/allow specific groups to make models, prompts, knowledge & tools public. This change is brought about because for large scale deployments, having users with workspace access be able to make everything public will end up as a large source of clutter. Admins can always set things to public.
If a user is a part of any group with a matching "Public" permission, they can the respective model/prompt/knowledge/tool public.
Added
Added additional permissions for groups in the workspace to allow/prevent specific groups to make models, prompts, knowledge & tools public.
Changed
Models, knowledge, prompts, & tools all now have "Private" visibility by default.
Screenshots or Videos
New permissions for groups:
As a user without permission, trying to make a model:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/8364
**Author:** [@tarmst](https://github.com/tarmst)
**Created:** 1/6/2025
**Status:** ❌ Closed
**Base:** `dev` ← **Head:** `toggle-option-make-models-knowledge-public`
---
### 📝 Commits (2)
- [`496d860`](https://github.com/open-webui/open-webui/commit/496d860b989d149aacd223ac351e28f51a306bc3) Add toggle options for visibility. Private visibility by default
- [`cf16185`](https://github.com/open-webui/open-webui/commit/cf1618595d317ec23522ae2e132ae1274f48aeb3) Remove unnecessary module declaration
### 📊 Changes
**8 files changed** (+81 additions, -7 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/routers/users.py` (+4 -0)
📝 `src/lib/components/admin/Users/Groups/Permissions.svelte` (+33 -1)
📝 `src/lib/components/workspace/Knowledge/CreateKnowledgeBase.svelte` (+2 -1)
📝 `src/lib/components/workspace/Models/ModelEditor.svelte` (+2 -1)
📝 `src/lib/components/workspace/Prompts/PromptEditor.svelte` (+2 -1)
📝 `src/lib/components/workspace/Tools/ToolkitEditor.svelte` (+2 -1)
📝 `src/lib/components/workspace/common/AccessControl.svelte` (+28 -2)
📝 `src/lib/types/index.ts` (+8 -0)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
Associated discussion: https://github.com/open-webui/open-webui/discussions/8054
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- No dependencies
- [x] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **feat**: Introduces a new feature or enhancement to the codebase
# Changelog Entry
### Description
- [Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)]
Added additional permissions for groups in the workspace to prevent/allow specific groups to make models, prompts, knowledge & tools public. This change is brought about because for large scale deployments, having users with workspace access be able to make everything public will end up as a large source of clutter. Admins can always set things to public.
If a user is a part of **any** group with a matching "Public" permission, they can the respective model/prompt/knowledge/tool public.
### Added
- Added additional permissions for groups in the workspace to allow/prevent specific groups to make models, prompts, knowledge & tools public.
### Changed
- Models, knowledge, prompts, & tools all now have "Private" visibility by default.
---
### Screenshots or Videos
New permissions for groups:
<img width="464" alt="Screenshot 2025-01-06 at 12 20 05 PM" src="https://github.com/user-attachments/assets/f7d6d13b-b1a4-482f-b80f-03d67a22a129" />
As a user without permission, trying to make a model:
<img width="459" alt="Screenshot 2025-01-06 at 12 24 06 PM" src="https://github.com/user-attachments/assets/7c41daf3-93f3-497b-9fec-7f5a3afd9f9e" />
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/8364
Author: @tarmst
Created: 1/6/2025
Status: ❌ Closed
Base:
dev← Head:toggle-option-make-models-knowledge-public📝 Commits (2)
496d860Add toggle options for visibility. Private visibility by defaultcf16185Remove unnecessary module declaration📊 Changes
8 files changed (+81 additions, -7 deletions)
View changed files
📝
backend/open_webui/routers/users.py(+4 -0)📝
src/lib/components/admin/Users/Groups/Permissions.svelte(+33 -1)📝
src/lib/components/workspace/Knowledge/CreateKnowledgeBase.svelte(+2 -1)📝
src/lib/components/workspace/Models/ModelEditor.svelte(+2 -1)📝
src/lib/components/workspace/Prompts/PromptEditor.svelte(+2 -1)📝
src/lib/components/workspace/Tools/ToolkitEditor.svelte(+2 -1)📝
src/lib/components/workspace/common/AccessControl.svelte(+28 -2)📝
src/lib/types/index.ts(+8 -0)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Associated discussion: https://github.com/open-webui/open-webui/discussions/8054
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Added additional permissions for groups in the workspace to prevent/allow specific groups to make models, prompts, knowledge & tools public. This change is brought about because for large scale deployments, having users with workspace access be able to make everything public will end up as a large source of clutter. Admins can always set things to public.
If a user is a part of any group with a matching "Public" permission, they can the respective model/prompt/knowledge/tool public.
Added
Changed
Screenshots or Videos
New permissions for groups:
As a user without permission, trying to make a model:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.