github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 06:03:26 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #8217] [MERGED] fix: Add missing request parameter to knowledge and retrieval routes #8978

New Issue
Closed
opened 2025-11-11 18:11:02 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 18:11:02 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/8217
Author: @gabriel-ecegi
Created: 12/30/2024
Status: ✅ Merged
Merged: 12/30/2024
Merged by: @tjbck

Base: dev ← Head: batch_fix

📝 Commits (2)

📊 Changes

2 files changed (+9 additions, -2 deletions)

View changed files

📝 backend/open_webui/routers/knowledge.py (+4 -1)
📝 backend/open_webui/routers/retrieval.py (+5 -1)

📄 Description

fix: Add missing request parameter to knowledge and retrieval routes

Pull Request Checklist

  • Target branch: Targeting dev branch
  • Description: Added missing request parameter to knowledge and retrieval route handlers
  • Changelog: Added below
  • Documentation: No documentation updates needed - internal API parameter fix
  • Dependencies: No new dependencies added
  • Testing: Manual testing of file upload and processing flows
  • Code review: Self-review completed
  • Prefix: Using fix prefix as this corrects a parameter omission

Changelog Entry

Fixed

  • Added missing request parameter to knowledge route /knowledge/{id}/files/batch/add
  • Added missing request parameter to retrieval route /process/files/batch
  • Updated function calls to pass request parameter correctly

Additional Information

Simple fix to add missing request parameter needed for proper file processing operations. The request object is required for handling file uploads and vector DB operations correctly.

No breaking changes or new dependencies were introduced.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/8217 **Author:** [@gabriel-ecegi](https://github.com/gabriel-ecegi) **Created:** 12/30/2024 **Status:** ✅ Merged **Merged:** 12/30/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `batch_fix` --- ### 📝 Commits (2) - [`ba2964c`](https://github.com/open-webui/open-webui/commit/ba2964cb015fcf023674816e1faa0ae6d1f77955) fix: missing parameter - [`46e5770`](https://github.com/open-webui/open-webui/commit/46e57706c18ad5d69a5ae695db5f1a72d03a9a45) refac: formatting ### 📊 Changes **2 files changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/knowledge.py` (+4 -1) 📝 `backend/open_webui/routers/retrieval.py` (+5 -1) </details> ### 📄 Description # fix: Add missing request parameter to knowledge and retrieval routes ## Pull Request Checklist - [x] **Target branch:** Targeting `dev` branch - [x] **Description:** Added missing request parameter to knowledge and retrieval route handlers - [x] **Changelog:** Added below - [x] **Documentation:** No documentation updates needed - internal API parameter fix - [x] **Dependencies:** No new dependencies added - [x] **Testing:** Manual testing of file upload and processing flows - [x] **Code review:** Self-review completed - [x] **Prefix:** Using `fix` prefix as this corrects a parameter omission ## Changelog Entry ### Fixed - Added missing `request` parameter to knowledge route `/knowledge/{id}/files/batch/add` - Added missing `request` parameter to retrieval route `/process/files/batch` - Updated function calls to pass request parameter correctly ## Additional Information Simple fix to add missing request parameter needed for proper file processing operations. The request object is required for handling file uploads and vector DB operations correctly. No breaking changes or new dependencies were introduced. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:11:02 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#8978
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?