github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #7907] [CLOSED] fix: use only non empty collections for completions #8927

New Issue
Closed
opened 2025-11-11 18:09:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 18:09:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/7907
Author: @gabriel-ecegi
Created: 12/17/2024
Status: ❌ Closed

Base: dev ← Head: empty_collection_fix

📝 Commits (1)

  • bea7a47 fix: use only non empty collections for completions

📊 Changes

1 file changed (+7 additions, -4 deletions)

View changed files

📝 src/lib/components/chat/Chat.svelte (+7 -4)

📄 Description

Pull Request Checklist

  • Target branch: Pull request targets the dev branch
  • Description: Filter out empty collections from completions to improve response quality
  • Changelog: Added below
  • Documentation: No documentation updates needed
  • Dependencies: No new dependencies
  • Testing: Code changes have been tested
  • Code review: Self-review completed
  • Prefix: Using fix: prefix as this addresses a bug/improvement

Changelog Entry

Description

This PR filters out empty collections from the completions to ensure only meaningful collections are included in the chat responses. This fixes the error for hybrid search.

Changed

  • Updated collection filtering logic in Chat.svelte to exclude empty collections

Fixed

  • Fixed issue where empty collections were being included in completions, causing error in hybrid search

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/7907 **Author:** [@gabriel-ecegi](https://github.com/gabriel-ecegi) **Created:** 12/17/2024 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `empty_collection_fix` --- ### 📝 Commits (1) - [`bea7a47`](https://github.com/open-webui/open-webui/commit/bea7a4799137fc3a92d576d86daffab002557d39) fix: use only non empty collections for completions ### 📊 Changes **1 file changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Chat.svelte` (+7 -4) </details> ### 📄 Description # Pull Request Checklist - [x] **Target branch:** Pull request targets the `dev` branch - [x] **Description:** Filter out empty collections from completions to improve response quality - [x] **Changelog:** Added below - [x] **Documentation:** No documentation updates needed - [x] **Dependencies:** No new dependencies - [x] **Testing:** Code changes have been tested - [x] **Code review:** Self-review completed - [x] **Prefix:** Using `fix:` prefix as this addresses a bug/improvement # Changelog Entry ### Description This PR filters out empty collections from the completions to ensure only meaningful collections are included in the chat responses. This fixes the error for hybrid search. ### Changed - Updated collection filtering logic in Chat.svelte to exclude empty collections ### Fixed - Fixed issue where empty collections were being included in completions, causing error in hybrid search --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:09:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#8927
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?