[PR #7807] [CLOSED] Fix encoding issues during download #8908

New Issue

GiteaMirror · 2025-11-11T18:09:13-06:00

GiteaMirror commented

2025-11-11 18:09:13 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/7807
Author: @chen2aaron
Created: 12/12/2024
Status: ❌ Closed

Base: dev ← Head: fix/encode

📝 Commits (1)

8763ec7 Fix encoding issues during download

📊 Changes

1 file changed (+5 additions, -10 deletions)

View changed files

📝 backend/open_webui/apps/webui/routers/files.py (+5 -10)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Fix this https://github.com/open-webui/open-webui/discussions/6480
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

When I upload a chinese file and want to download it, it will raise error:

{
    "detail": "[ERROR: Error getting file content]"
}

The reason is that the method calling Starlette is incorrect. There is no need to pass a header parameter when use FileResponse, only filename needs to be passed, and Starlette will handle it internally.

Related discussions: https://github.com/open-webui/open-webui/discussions/6480
Related PR with Starlette:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/7807 **Author:** [@chen2aaron](https://github.com/chen2aaron) **Created:** 12/12/2024 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/encode` --- ### 📝 Commits (1) - [`8763ec7`](https://github.com/open-webui/open-webui/commit/8763ec731456a74fa31eb16c6c6e7a5c5d7f05c1) Fix encoding issues during download ### 📊 Changes **1 file changed** (+5 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/apps/webui/routers/files.py` (+5 -10) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Fix this https://github.com/open-webui/open-webui/discussions/6480 - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description When I upload a chinese file and want to download it, it will raise error: ```json { "detail": "[ERROR: Error getting file content]" } ``` The reason is that the method calling Starlette is incorrect. There is no need to pass a header parameter when use `FileResponse`, only filename needs to be passed, and Starlette will handle it internally. Related discussions: https://github.com/open-webui/open-webui/discussions/6480 Related PR with Starlette: - https://github.com/encode/starlette/pull/792 - https://github.com/encode/starlette/pull/790 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 18:09:13 -06:00

GiteaMirror closed this issue

2025-11-11 18:09:13 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#8908