github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-03-10 15:54:15 -05:00
Code Issues 308 Packages Projects Releases 100 Wiki Activity

[PR #6701] [MERGED] Small Fix: variable from ssl_verification to: web_loader_ssl_verification #8732

New Issue
Closed
opened 2025-11-11 18:04:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 18:04:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/6701
Author: @davizucon
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/4/2024
Merged by: @tjbck

Base: dev ← Head: dev

📝 Commits (3)

  • 5306b49 Small Fix variable ssl_verification -> web_loader_ssl_verification (following python entity)
  • 35a9140 Added parameter to: app.state.config.ENABLE_RAG_WEB_LOADER_SSL_VERIFICATION to get_web_loader(verify_ssl).
  • a70e5a0 When UI "Bypass SSL verification for Websites"=True then ENABLE_RAG_WEB_LOADER_SSL_VERIFICATION=False

📊 Changes

2 files changed (+6 additions, -5 deletions)

View changed files

📝 backend/open_webui/apps/retrieval/main.py (+4 -3)
📝 src/lib/components/admin/Settings/WebSearch.svelte (+2 -2)

📄 Description

When changed via web UI, Admin->WebSearch->Bypass SSL verification for Websites, the option is not being persisted. This change fixes it to correctly persist the value.

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • [Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)]

Added

  • [List any new features, functionalities, or additions]

Changed

The name of the variable ssl_verification was changed to web_loader_ssl_verification, places:

  • in the response json to load the screen, GET config endpoint;
  • when sending the configuration to the POST config/update endpoint;
  • changed the get_web_loader() method to pass the ENABLE_RAG_WEB_LOADER_SSL_VERIFICATION parameter, it was fixed at True.

The behavior of the screen was changed to adapt to the value of the variable "ENABLE_RAG_WEB_LOADER_SSL_VERIFICATION":

  • When on (True) to "Bypass SSL verification for Websites", that is, when the bypass is enabled, the SSL enablement variable "ENABLE_RAG_WEB_LOADER_SSL_VERIFICATION" must be False.

Deprecated

  • [List any deprecated functionality or features that have been removed]

Removed

  • [List any removed features, files, or functionalities]

Fixed

  • [List any fixes, corrections, or bug fixes]

Security

  • [List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

  • BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

  • [Insert any additional context, notes, or explanations for the changes]
    • [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/6701 **Author:** [@davizucon](https://github.com/davizucon) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/4/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (3) - [`5306b49`](https://github.com/open-webui/open-webui/commit/5306b49be0d8139d96b84508a1d70a11c9d9be21) Small Fix variable ssl_verification -> web_loader_ssl_verification (following python entity) - [`35a9140`](https://github.com/open-webui/open-webui/commit/35a91405675aeb47ed134ea3293a67bfb353bcb5) Added parameter to: app.state.config.ENABLE_RAG_WEB_LOADER_SSL_VERIFICATION to get_web_loader(verify_ssl). - [`a70e5a0`](https://github.com/open-webui/open-webui/commit/a70e5a0f303cbe37d1c8007c99e633afa167bf3a) When UI "Bypass SSL verification for Websites"=True then ENABLE_RAG_WEB_LOADER_SSL_VERIFICATION=False ### 📊 Changes **2 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/apps/retrieval/main.py` (+4 -3) 📝 `src/lib/components/admin/Settings/WebSearch.svelte` (+2 -2) </details> ### 📄 Description When changed via web UI, Admin->WebSearch->Bypass SSL verification for Websites, the option is not being persisted. This change fixes it to correctly persist the value. # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [ ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - [Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)] ### Added - [List any new features, functionalities, or additions] ### Changed The name of the variable ssl_verification was changed to web_loader_ssl_verification, places: - in the response json to load the screen, GET config endpoint; - when sending the configuration to the POST config/update endpoint; - changed the get_web_loader() method to pass the ENABLE_RAG_WEB_LOADER_SSL_VERIFICATION parameter, it was fixed at True. The behavior of the screen was changed to adapt to the value of the variable "ENABLE_RAG_WEB_LOADER_SSL_VERIFICATION": - When on (True) to "Bypass SSL verification for Websites", that is, when the bypass is enabled, the SSL enablement variable "ENABLE_RAG_WEB_LOADER_SSL_VERIFICATION" must be False. ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - [List any fixes, corrections, or bug fixes] ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:04:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#8732
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?