File processing may fall due to many reasons (fwiw, in my case it was old .doc upload - note, I'm not for supporting this format). Now file processing error is logged, but not propagated. So, UI looks like everything is fine. I think it's worth to throw through the underneath error, at least to display alarm box informing about troubles.
Pull Request Checklist
Before submitting, make sure you've checked the following:
[v] Target branch: Please verify that the pull request targets the dev branch.
[v] Description: Provide a concise description of the changes made in this pull request.
[v] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[-] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
[-] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[-] Testing: Have you written and run sufficient tests for validating the changes?
[v] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
[v] Prefix:
Changelog Entry
Description
Propagate processing error for uploaded files.
Fixed
Bug: uploaded file processing error silently ignored and just logged.
Additional Information
that how it's logged (when fixed):
INFO [open_webui.apps.webui.routers.files] file.content_type: application/msword
DEBUG [open_webui.apps.retrieval.main] text_content:
INFO [open_webui.apps.retrieval.main] save_docs_to_vector_db [Document(metadata={'source': '/app/backend/data/uploads/b3a3bef4-d7c9-42b9-a828-b7ae7537a1d0_1_3Polit2_T_Dmitr2.doc'}, page_content='')] file-b3a3bef4-d7c9-42b9-a828-b7ae7537a1d0
ERROR [open_webui.apps.retrieval.main] The content provided is empty. Please ensure that there is text or data present before proceeding.
Traceback (most recent call last):
File "/app/backend/open_webui/apps/retrieval/main.py", line 858, in process_file
raise e
File "/app/backend/open_webui/apps/retrieval/main.py", line 832, in process_file
result = save_docs_to_vector_db(
^^^^^^^^^^^^^^^^^^^^^^^
File "/app/backend/open_webui/apps/retrieval/main.py", line 663, in save_docs_to_vector_db
raise ValueError(ERROR_MESSAGES.EMPTY_CONTENT)
ValueError: The content provided is empty. Please ensure that there is text or data present before proceeding.
ERROR [open_webui.apps.webui.routers.files] 400: The content provided is empty. Please ensure that there is text or data present before proceeding.
Traceback (most recent call last):
File "/app/backend/open_webui/apps/retrieval/main.py", line 858, in process_file
raise e
File "/app/backend/open_webui/apps/retrieval/main.py", line 832, in process_file
result = save_docs_to_vector_db(
^^^^^^^^^^^^^^^^^^^^^^^
File "/app/backend/open_webui/apps/retrieval/main.py", line 663, in save_docs_to_vector_db
raise ValueError(ERROR_MESSAGES.EMPTY_CONTENT)
ValueError: The content provided is empty. Please ensure that there is text or data present before proceeding.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/backend/open_webui/apps/webui/routers/files.py", line 71, in upload_file
process_file(ProcessFileForm(file_id=id))
File "/app/backend/open_webui/apps/retrieval/main.py", line 867, in process_file
raise HTTPException(
fastapi.exceptions.HTTPException: 400: The content provided is empty. Please ensure that there is text or data present before proceeding.
ERROR [open_webui.apps.webui.routers.files] Error processing file: b3a3bef4-d7c9-42b9-a828-b7ae7537a1d0
ERROR [open_webui.apps.webui.routers.files] 400: The content provided is empty. Please ensure that there is text or data present before proceeding.
Traceback (most recent call last):
File "/app/backend/open_webui/apps/retrieval/main.py", line 858, in process_file
raise e
File "/app/backend/open_webui/apps/retrieval/main.py", line 832, in process_file
result = save_docs_to_vector_db(
^^^^^^^^^^^^^^^^^^^^^^^
File "/app/backend/open_webui/apps/retrieval/main.py", line 663, in save_docs_to_vector_db
raise ValueError(ERROR_MESSAGES.EMPTY_CONTENT)
ValueError: The content provided is empty. Please ensure that there is text or data present before proceeding.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/backend/open_webui/apps/webui/routers/files.py", line 76, in upload_file
raise e
File "/app/backend/open_webui/apps/webui/routers/files.py", line 71, in upload_file
process_file(ProcessFileForm(file_id=id))
File "/app/backend/open_webui/apps/retrieval/main.py", line 867, in process_file
raise HTTPException(
fastapi.exceptions.HTTPException: 400: The content provided is empty. Please ensure that there is text or data present before proceeding.
DEBUG [open_webui.main] Commit session after request
Collection file-b3a3bef4-d7c9-42b9-a828-b7ae7537a1d0 does not exist.
INFO: 172.17.0.1:49574 - "POST /api/v1/files/ HTTP/1.1" 400 Bad Request
Screenshots or Videos
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/6438
**Author:** [@mkhludnev](https://github.com/mkhludnev)
**Created:** 10/26/2024
**Status:** ❌ Closed
**Base:** `dev` ← **Head:** `patch-1`
---
### 📝 Commits (1)
- [`c7e23fd`](https://github.com/open-webui/open-webui/commit/c7e23fdf7a8f4d0c54ab2344d68840da281aa707) Propagate file processing error to UI
### 📊 Changes
**1 file changed** (+1 additions, -0 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/apps/webui/routers/files.py` (+1 -0)
</details>
### 📄 Description
File processing may fall due to many reasons (fwiw, in my case it was old .doc upload - note, I'm not for supporting this format). Now file processing error is logged, but not propagated. So, UI looks like everything is fine. I think it's worth to throw through the underneath error, at least to display alarm box informing about troubles.
# Pull Request Checklist
**Before submitting, make sure you've checked the following:**
- [v] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [v] **Description:** Provide a concise description of the changes made in this pull request.
- [v] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [-] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [-] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [-] **Testing:** Have you written and run sufficient tests for validating the changes?
- [v] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [v] **Prefix:**
# Changelog Entry
### Description
- Propagate processing error for uploaded files.
### Fixed
- Bug: uploaded file processing error silently ignored and just logged.
---
### Additional Information
that how it's logged (when fixed):
```
INFO [open_webui.apps.webui.routers.files] file.content_type: application/msword
DEBUG [open_webui.apps.retrieval.main] text_content:
INFO [open_webui.apps.retrieval.main] save_docs_to_vector_db [Document(metadata={'source': '/app/backend/data/uploads/b3a3bef4-d7c9-42b9-a828-b7ae7537a1d0_1_3Polit2_T_Dmitr2.doc'}, page_content='')] file-b3a3bef4-d7c9-42b9-a828-b7ae7537a1d0
ERROR [open_webui.apps.retrieval.main] The content provided is empty. Please ensure that there is text or data present before proceeding.
Traceback (most recent call last):
File "/app/backend/open_webui/apps/retrieval/main.py", line 858, in process_file
raise e
File "/app/backend/open_webui/apps/retrieval/main.py", line 832, in process_file
result = save_docs_to_vector_db(
^^^^^^^^^^^^^^^^^^^^^^^
File "/app/backend/open_webui/apps/retrieval/main.py", line 663, in save_docs_to_vector_db
raise ValueError(ERROR_MESSAGES.EMPTY_CONTENT)
ValueError: The content provided is empty. Please ensure that there is text or data present before proceeding.
ERROR [open_webui.apps.webui.routers.files] 400: The content provided is empty. Please ensure that there is text or data present before proceeding.
Traceback (most recent call last):
File "/app/backend/open_webui/apps/retrieval/main.py", line 858, in process_file
raise e
File "/app/backend/open_webui/apps/retrieval/main.py", line 832, in process_file
result = save_docs_to_vector_db(
^^^^^^^^^^^^^^^^^^^^^^^
File "/app/backend/open_webui/apps/retrieval/main.py", line 663, in save_docs_to_vector_db
raise ValueError(ERROR_MESSAGES.EMPTY_CONTENT)
ValueError: The content provided is empty. Please ensure that there is text or data present before proceeding.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/backend/open_webui/apps/webui/routers/files.py", line 71, in upload_file
process_file(ProcessFileForm(file_id=id))
File "/app/backend/open_webui/apps/retrieval/main.py", line 867, in process_file
raise HTTPException(
fastapi.exceptions.HTTPException: 400: The content provided is empty. Please ensure that there is text or data present before proceeding.
ERROR [open_webui.apps.webui.routers.files] Error processing file: b3a3bef4-d7c9-42b9-a828-b7ae7537a1d0
ERROR [open_webui.apps.webui.routers.files] 400: The content provided is empty. Please ensure that there is text or data present before proceeding.
Traceback (most recent call last):
File "/app/backend/open_webui/apps/retrieval/main.py", line 858, in process_file
raise e
File "/app/backend/open_webui/apps/retrieval/main.py", line 832, in process_file
result = save_docs_to_vector_db(
^^^^^^^^^^^^^^^^^^^^^^^
File "/app/backend/open_webui/apps/retrieval/main.py", line 663, in save_docs_to_vector_db
raise ValueError(ERROR_MESSAGES.EMPTY_CONTENT)
ValueError: The content provided is empty. Please ensure that there is text or data present before proceeding.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/backend/open_webui/apps/webui/routers/files.py", line 76, in upload_file
raise e
File "/app/backend/open_webui/apps/webui/routers/files.py", line 71, in upload_file
process_file(ProcessFileForm(file_id=id))
File "/app/backend/open_webui/apps/retrieval/main.py", line 867, in process_file
raise HTTPException(
fastapi.exceptions.HTTPException: 400: The content provided is empty. Please ensure that there is text or data present before proceeding.
DEBUG [open_webui.main] Commit session after request
Collection file-b3a3bef4-d7c9-42b9-a828-b7ae7537a1d0 does not exist.
INFO: 172.17.0.1:49574 - "POST /api/v1/files/ HTTP/1.1" 400 Bad Request
```
### Screenshots or Videos
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/6438
Author: @mkhludnev
Created: 10/26/2024
Status: ❌ Closed
Base:
dev← Head:patch-1📝 Commits (1)
c7e23fdPropagate file processing error to UI📊 Changes
1 file changed (+1 additions, -0 deletions)
View changed files
📝
backend/open_webui/apps/webui/routers/files.py(+1 -0)📄 Description
File processing may fall due to many reasons (fwiw, in my case it was old .doc upload - note, I'm not for supporting this format). Now file processing error is logged, but not propagated. So, UI looks like everything is fine. I think it's worth to throw through the underneath error, at least to display alarm box informing about troubles.
Pull Request Checklist
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Fixed
Additional Information
that how it's logged (when fixed):
Screenshots or Videos
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.