github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-03-10 07:43:10 -05:00
Code Issues 308 Packages Projects Releases 100 Wiki Activity

[PR #6392] [MERGED] fix: boolean values don't need to be accessed by .value #8672

New Issue
Closed
opened 2025-11-11 18:02:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 18:02:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/6392
Author: @nodomain
Created: 10/25/2024
Status: ✅ Merged
Merged: 10/25/2024
Merged by: @tjbck

Base: dev ← Head: patch-1

📝 Commits (6)

📊 Changes

3 files changed (+26 additions, -6 deletions)

View changed files

📝 .github/ISSUE_TEMPLATE/bug_report.md (+12 -2)
📝 .github/ISSUE_TEMPLATE/feature_request.md (+12 -2)
📝 backend/open_webui/utils/oauth.py (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Removed the .value access for OIDC related settings.

Fixed

  • Boolean environment variables OAUTH_MERGE_ACCOUNTS_BY_EMAIL and ENABLE_OAUTH_SIGNUP were falsely accessed by .value and hence OIDC auth failed.

Additional Information

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/6392 **Author:** [@nodomain](https://github.com/nodomain) **Created:** 10/25/2024 **Status:** ✅ Merged **Merged:** 10/25/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `patch-1` --- ### 📝 Commits (6) - [`99dd7fb`](https://github.com/open-webui/open-webui/commit/99dd7fb5a836511e02e2a3761aeab75f2e8b5687) Merge pull request #6002 from open-webui/dev - [`9b12b75`](https://github.com/open-webui/open-webui/commit/9b12b75df63a3b0aafbeafeb93f46d2861cb1f37) Merge pull request #6380 from open-webui/dev - [`68916f7`](https://github.com/open-webui/open-webui/commit/68916f7ec4bd699c17f97fdf6a60e8e8784f659d) Merge pull request #6382 from open-webui/dev - [`144dc0e`](https://github.com/open-webui/open-webui/commit/144dc0ed2fa30b01c1f1ed72714f3bd2ca479c34) Merge pull request #6383 from open-webui/dev - [`d905bda`](https://github.com/open-webui/open-webui/commit/d905bda000af3d84e1c59f54243537ce249829b7) refac: template notes - [`2346133`](https://github.com/open-webui/open-webui/commit/23461332b916e53f1c6ec3661975565ca3394d8e) fix: boolean values don't need to be accessed by .value ### 📊 Changes **3 files changed** (+26 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `.github/ISSUE_TEMPLATE/bug_report.md` (+12 -2) 📝 `.github/ISSUE_TEMPLATE/feature_request.md` (+12 -2) 📝 `backend/open_webui/utils/oauth.py` (+2 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Removed the `.value` access for OIDC related settings. ### Fixed - Boolean environment variables `OAUTH_MERGE_ACCOUNTS_BY_EMAIL` and `ENABLE_OAUTH_SIGNUP` were falsely accessed by `.value` and hence OIDC auth failed. --- ### Additional Information - fixes #6384 ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:02:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#8672
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?