[PR #6199] [CLOSED] fix: hide those models which are marked as hidden by admin in workspace #8636

New Issue

GiteaMirror · 2025-11-11T18:01:41-06:00

GiteaMirror commented

2025-11-11 18:01:41 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/6199
Author: @kevinleeex
Created: 10/15/2024
Status: ❌ Closed

Base: dev ← Head: bugfix/hide-hidden-models

📝 Commits (1)

08acff9 bugfix: hide those models which are marked as hidden by admin in workspace.

📊 Changes

3 files changed (+3 additions, -2 deletions)

View changed files

📝 src/lib/apis/index.ts (+1 -0)
📝 src/lib/components/admin/Settings/Users.svelte (+1 -1)
📝 src/lib/components/chat/Settings/Interface.svelte (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Add model meta property checking to filter those hidden models, just like the logic being applied to the model selection in the home chat view.

Fixed

Fixed #6197 , to filter those hidden models as it's been done to the home chat view when selecting a model.

Additional Information

Maybe filter them out in the API makes more sense?

Screenshots or Videos

Before:

When mark those models as hidden, they are still showing in Settings/Interface for selecting default model.

After:

After filter the hidden models, they are really hidden from the user list.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/6199 **Author:** [@kevinleeex](https://github.com/kevinleeex) **Created:** 10/15/2024 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `bugfix/hide-hidden-models` --- ### 📝 Commits (1) - [`08acff9`](https://github.com/open-webui/open-webui/commit/08acff916c62f086af61d1d3f3e7b308346297f7) bugfix: hide those models which are marked as hidden by admin in workspace. ### 📊 Changes **3 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/apis/index.ts` (+1 -0) 📝 `src/lib/components/admin/Settings/Users.svelte` (+1 -1) 📝 `src/lib/components/chat/Settings/Interface.svelte` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Add model meta property checking to filter those hidden models, just like the logic being applied to the model selection in the home chat view. <img width="565" alt="image" src="https://github.com/user-attachments/assets/f2feef94-2729-4565-8396-ba10c4471f6c"> ### Fixed Fixed #6197 , to filter those hidden models as it's been done to the home chat view when selecting a model. ### Additional Information Maybe filter them out in the API makes more sense? ### Screenshots or Videos **Before:** ![image](https://github.com/user-attachments/assets/97e577bb-d59c-4d4b-b1cd-90e12f9a297c) ![image](https://github.com/user-attachments/assets/eb40522f-9976-415e-a56f-e984b9070881) **When mark those models as hidden, they are still showing in `Settings/Interface` for selecting default model.** **After:** ![image](https://github.com/user-attachments/assets/c1827a5f-8b2d-43a2-937e-1ae63d9176af) ![image](https://github.com/user-attachments/assets/90d9a9cb-9625-4bfe-9cd8-70d0859a533e) After filter the hidden models, they are really hidden from the user list. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 18:01:41 -06:00

GiteaMirror closed this issue

2025-11-11 18:01:41 -06:00

GiteaMirror referenced this issue

2026-04-19 21:28:27 -05:00

[GH-ISSUE #8636] The UI stop working after invalid parameter passed to toast.error() #15201

GiteaMirror referenced this issue

2026-04-25 04:57:50 -05:00

[GH-ISSUE #8636] The UI stop working after invalid parameter passed to toast.error() #30729

GiteaMirror referenced this issue

2026-05-05 15:28:00 -05:00

[GH-ISSUE #8636] The UI stop working after invalid parameter passed to toast.error() #53867