[PR #5436] [MERGED] fix: model transparent icons #8484

Closed
opened 2025-11-11 17:57:47 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/5436
Author: @khanh-alice
Created: 9/15/2024
Status: Merged
Merged: 9/16/2024
Merged by: @tjbck

Base: devHead: fix-transparent-icons


📝 Commits (1)

📊 Changes

3 files changed (+7 additions, -7 deletions)

View changed files

📝 src/lib/components/workspace/Models.svelte (+1 -1)
📝 src/routes/(app)/workspace/models/create/+page.svelte (+3 -3)
📝 src/routes/(app)/workspace/models/edit/+page.svelte (+3 -3)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Fix an issue where saved transparent icons are not displayed with transparent.

Fixed

  • Model icons are now saved as png instead of jpeg, this allows icon to be transparent. This change does not affect already saved jpeg icons.
  • Allow uploading svg icons.

Screenshots or Videos

Light theme

image image image

Dark theme

image image image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/5436 **Author:** [@khanh-alice](https://github.com/khanh-alice) **Created:** 9/15/2024 **Status:** ✅ Merged **Merged:** 9/16/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-transparent-icons` --- ### 📝 Commits (1) - [`253791b`](https://github.com/open-webui/open-webui/commit/253791b92cdfe1267ffc38e084711763fd19d765) save model icon as png ### 📊 Changes **3 files changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/workspace/Models.svelte` (+1 -1) 📝 `src/routes/(app)/workspace/models/create/+page.svelte` (+3 -3) 📝 `src/routes/(app)/workspace/models/edit/+page.svelte` (+3 -3) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fix an issue where saved transparent icons are not displayed with transparent. ### Fixed - Model icons are now saved as png instead of jpeg, this allows icon to be transparent. This change does not affect already saved jpeg icons. - Allow uploading svg icons. --- ### Screenshots or Videos #### Light theme <img width="1140" alt="image" src="https://github.com/user-attachments/assets/06134056-1324-408d-95b3-eff1406262c6"> <img width="1140" alt="image" src="https://github.com/user-attachments/assets/ca1bc7ff-5a1a-4d23-bb55-3da1e74766b5"> <img width="1140" alt="image" src="https://github.com/user-attachments/assets/e0d3567a-0a1e-416c-85e4-b38adc4a433a"> #### Dark theme <img width="1140" alt="image" src="https://github.com/user-attachments/assets/081d8db9-2d5b-47ac-a77d-3b599e473764"> <img width="1140" alt="image" src="https://github.com/user-attachments/assets/035cdefe-967b-4d59-8a6a-20fd25f36457"> <img width="1140" alt="image" src="https://github.com/user-attachments/assets/2128dd6e-5e08-4712-b117-16aca0b2ce85"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:57:47 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#8484