mirror of
https://github.com/open-webui/open-webui.git
synced 2026-06-03 07:24:59 -05:00
[PR #5076] [MERGED] fix: chat errors when websocket unavailable #8420
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/5076
Author: @cheahjs
Created: 9/1/2024
Status: ✅ Merged
Merged: 9/3/2024
Merged by: @tjbck
Base:
dev← Head:fix/websocket-error-object📝 Commits (1)
4946f08fix: force socket.io to try websockets first, and explicit fallback to polling📊 Changes
1 file changed (+54 additions, -39 deletions)
View changed files
📝
src/routes/+layout.svelte(+54 -39)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
socket.iodoesn't seem to be upgrading from long-polling to websockets correctly, a failure to upgrade can break the socket, where it's still internally long-polling, but theconnectevent is never sent. So forcibly trywebsocketfirst, and then downgrade topollingif it fails.Added
Changed
Deprecated
Removed
Fixed
Security
Breaking Changes
Additional Information
Stack trace from bug (missing
session-id):Screenshots or Videos
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.