[PR #4973] [MERGED] A11y: Add missing aria labels for buttons #8398

Closed
opened 2025-11-11 17:55:28 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/4973
Author: @sebdanielsson
Created: 8/28/2024
Status: Merged
Merged: 8/30/2024
Merged by: @tjbck

Base: devHead: ally-aria-labels


📝 Commits (1)

  • 22117e0 A11y: Buttons do not have an accessible name

📊 Changes

6 files changed (+11 additions, -0 deletions)

View changed files

📝 src/lib/components/chat/MessageInput.svelte (+3 -0)
📝 src/lib/components/chat/ModelSelector.svelte (+2 -0)
📝 src/lib/components/layout/Navbar.svelte (+3 -0)
📝 src/routes/(app)/admin/+layout.svelte (+1 -0)
📝 src/routes/(app)/playground/+layout.svelte (+1 -0)
📝 src/routes/(app)/workspace/+layout.svelte (+1 -0)

📄 Description

Changelog Entry

Description

This PR adds some missing aria labels on button elements that Lighthouse warned about. This was previously part of a slightly bigger PR #4942 which fixed all problematic elements on the login and start page but as per your suggestions I created a new PR without style changes in case this is part of a larger redesign for a future release.

Fixed

  • Missing aria labels on buttons have been added, enhancing the Lighthouse accessibility test results.

Additional Information

Partly fixes #2790


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/4973 **Author:** [@sebdanielsson](https://github.com/sebdanielsson) **Created:** 8/28/2024 **Status:** ✅ Merged **Merged:** 8/30/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `ally-aria-labels` --- ### 📝 Commits (1) - [`22117e0`](https://github.com/open-webui/open-webui/commit/22117e06b54ec8c962169c6a91fb2529a448aee4) A11y: Buttons do not have an accessible name ### 📊 Changes **6 files changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/MessageInput.svelte` (+3 -0) 📝 `src/lib/components/chat/ModelSelector.svelte` (+2 -0) 📝 `src/lib/components/layout/Navbar.svelte` (+3 -0) 📝 `src/routes/(app)/admin/+layout.svelte` (+1 -0) 📝 `src/routes/(app)/playground/+layout.svelte` (+1 -0) 📝 `src/routes/(app)/workspace/+layout.svelte` (+1 -0) </details> ### 📄 Description # Changelog Entry ### Description This PR adds some missing aria labels on button elements that Lighthouse warned about. This was previously part of a slightly bigger PR #4942 which fixed all problematic elements on the login and start page but as per your suggestions I created a new PR without style changes in case this is part of a larger redesign for a future release. ### Fixed - Missing aria labels on buttons have been added, enhancing the Lighthouse accessibility test results. --- ### Additional Information Partly fixes #2790 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:55:28 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#8398