[PR #4957] [MERGED] fix: sort and fix backend imports #8395

Closed
opened 2025-11-11 17:52:45 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/4957
Author: @pascallim
Created: 8/27/2024
Status: Merged
Merged: 8/31/2024
Merged by: @tjbck

Base: devHead: fix/imports


📝 Commits (2)

📊 Changes

64 files changed (+550 additions, -976 deletions)

View changed files

📝 backend/apps/audio/main.py (+19 -32)
📝 backend/apps/images/main.py (+23 -35)
📝 backend/apps/images/utils/comfyui.py (+7 -9)
📝 backend/apps/ollama/main.py (+19 -33)
📝 backend/apps/openai/main.py (+21 -29)
📝 backend/apps/rag/main.py (+87 -116)
📝 backend/apps/rag/search/brave.py (+2 -2)
📝 backend/apps/rag/search/duckduckgo.py (+2 -1)
📝 backend/apps/rag/search/google_pse.py (+2 -3)
📝 backend/apps/rag/search/jina_search.py (+3 -3)
📝 backend/apps/rag/search/main.py (+1 -0)
📝 backend/apps/rag/search/searchapi.py (+2 -3)
📝 backend/apps/rag/search/searxng.py (+2 -3)
📝 backend/apps/rag/search/serper.py (+2 -2)
📝 backend/apps/rag/search/serply.py (+2 -3)
📝 backend/apps/rag/search/serpstack.py (+2 -3)
📝 backend/apps/rag/search/tavily.py (+1 -2)
📝 backend/apps/rag/utils.py (+14 -24)
📝 backend/apps/socket/main.py (+1 -2)
📝 backend/apps/webui/internal/db.py (+9 -14)

...and 44 more files

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:

Changelog Entry

Description

  • Fix imports by referencing to correct files. Sometimes imports are from different files and unused imports permit to make the whole application works but this is may break sometimes.

Changed

  • Refacto by sorting and removing unused imports
  • Light refacto on some files

Fixed

  • Points import to correct python files to avoid weird behaviors in the future.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/4957 **Author:** [@pascallim](https://github.com/pascallim) **Created:** 8/27/2024 **Status:** ✅ Merged **Merged:** 8/31/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/imports` --- ### 📝 Commits (2) - [`c386d0b`](https://github.com/open-webui/open-webui/commit/c386d0b1a51534b00b603a9107ad50030152dd19) sort and fix backend imports - [`9232e03`](https://github.com/open-webui/open-webui/commit/9232e0310276ecb19ab73529332bcb98adf4c864) fix imports ### 📊 Changes **64 files changed** (+550 additions, -976 deletions) <details> <summary>View changed files</summary> 📝 `backend/apps/audio/main.py` (+19 -32) 📝 `backend/apps/images/main.py` (+23 -35) 📝 `backend/apps/images/utils/comfyui.py` (+7 -9) 📝 `backend/apps/ollama/main.py` (+19 -33) 📝 `backend/apps/openai/main.py` (+21 -29) 📝 `backend/apps/rag/main.py` (+87 -116) 📝 `backend/apps/rag/search/brave.py` (+2 -2) 📝 `backend/apps/rag/search/duckduckgo.py` (+2 -1) 📝 `backend/apps/rag/search/google_pse.py` (+2 -3) 📝 `backend/apps/rag/search/jina_search.py` (+3 -3) 📝 `backend/apps/rag/search/main.py` (+1 -0) 📝 `backend/apps/rag/search/searchapi.py` (+2 -3) 📝 `backend/apps/rag/search/searxng.py` (+2 -3) 📝 `backend/apps/rag/search/serper.py` (+2 -2) 📝 `backend/apps/rag/search/serply.py` (+2 -3) 📝 `backend/apps/rag/search/serpstack.py` (+2 -3) 📝 `backend/apps/rag/search/tavily.py` (+1 -2) 📝 `backend/apps/rag/utils.py` (+14 -24) 📝 `backend/apps/socket/main.py` (+1 -2) 📝 `backend/apps/webui/internal/db.py` (+9 -14) _...and 44 more files_ </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: # Changelog Entry ### Description - Fix imports by referencing to correct files. Sometimes imports are from different files and unused imports permit to make the whole application works but this is may break sometimes. ### Changed - Refacto by sorting and removing unused imports - Light refacto on some files ### Fixed - Points import to correct python files to avoid weird behaviors in the future. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:52:45 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#8395