[PR #4333] [MERGED] fix: made the COMFYUI_FLUX_FP8_CLIP environment variable bool instead of str #8258

New Issue

GiteaMirror · 2025-11-11T17:49:11-06:00

GiteaMirror commented

2025-11-11 17:49:11 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/4333
Author: @JohnTheNerd
Created: 8/3/2024
Status: ✅ Merged
Merged: 8/4/2024
Merged by: @tjbck

Base: dev ← Head: comfyui-fix

📝 Commits (1)

cdcf214 made the COMFYUI_FLUX_FP8_CLIP environment variable bool instead of str

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/config.py (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

in #4300, I accidentally defined COMFYUI_FLUX_FP8_CLIP as a string instead of a boolean in config.py - which upsets Pydantic when it's not set and therefore is an empty string

Added

n/a

Changed

COMFYUI_FLUX_FP8_CLIP is now expected to be "true" or "false", defaulting to "false".

Deprecated

n/a

Removed

n/a

Fixed

this PR should fix #4328

Security

n/a

Breaking Changes

n/a

Additional Information

I built the Dockerfile and pushed it to ghcr.io/johnthenerd/open-webui:comfyui-fix - something is preventing me from running the GitHub Actions since my last round of PR's (GHCR just 403s in the push stage) and I'd rather get the fix out instead of investigating it.

This does mean I only have the x86 image without CUDA or ollama in that tag above since I just build and push from my laptop, but it should suffice for testing.

Screenshots or Videos

environment variable not set, before this PR:

I'm not able to provide an "after this PR" screenshot with fp16 (which is the default without the variable set) as I do not have enough RAM/VRAM to do so and therefore my entire server starts thrashing when I try. I can however confirm that the error message no longer appears and the ComfyUI request is set correctly regardless of the environment variable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/4333 **Author:** [@JohnTheNerd](https://github.com/JohnTheNerd) **Created:** 8/3/2024 **Status:** ✅ Merged **Merged:** 8/4/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `comfyui-fix` --- ### 📝 Commits (1) - [`cdcf214`](https://github.com/open-webui/open-webui/commit/cdcf2144550146ebc35b876ac05f10b8de31a012) made the COMFYUI_FLUX_FP8_CLIP environment variable bool instead of str ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/config.py` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description in #4300, I accidentally defined COMFYUI_FLUX_FP8_CLIP as a string instead of a boolean in config.py - which upsets Pydantic when it's not set and therefore is an empty string ### Added n/a ### Changed COMFYUI_FLUX_FP8_CLIP is now expected to be "true" or "false", defaulting to "false". ### Deprecated n/a ### Removed n/a ### Fixed this PR should fix #4328 ### Security n/a ### Breaking Changes n/a --- ### Additional Information I built the Dockerfile and pushed it to `ghcr.io/johnthenerd/open-webui:comfyui-fix` - something is preventing me from running the GitHub Actions since my last round of PR's (GHCR just 403s in the push stage) and I'd rather get the fix out instead of investigating it. This does mean I only have the x86 image without CUDA or ollama in that tag above since I just build and push from my laptop, but it should suffice for testing. ### Screenshots or Videos environment variable not set, before this PR: ![image](https://github.com/user-attachments/assets/a5b07602-9aff-4c1c-bd68-547e13f4fd7c) I'm not able to provide an "after this PR" screenshot with fp16 (which is the default without the variable set) as I do not have enough RAM/VRAM to do so and therefore my entire server starts thrashing when I try. I can however confirm that the error message no longer appears and the ComfyUI request is set correctly regardless of the environment variable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 17:49:11 -06:00

GiteaMirror closed this issue

2025-11-11 17:49:12 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#8258