[PR #24518] [MERGED] chore: add validate_url() to get_image_data() for cohort consistency hardening #82574

New Issue

GiteaMirror · 2026-05-13T17:07:29-05:00

GiteaMirror commented

2026-05-13 17:07:29 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24518
Author: @Classic298
Created: 5/9/2026
Status: ✅ Merged
Merged: 5/10/2026
Merged by: @tjbck

Base: dev ← Head: chore/get-image-data-validate-url-hardening

📝 Commits (2)

20d54ad chore: add validate_url() to get_image_data() for cohort consistency hardening
f5ff199 chore: trim comment

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 backend/open_webui/routers/images.py (+2 -0)

📄 Description

get_image_data() in backend/open_webui/routers/images.py fetches the URL returned by the configured image generation API directly via session.get(data) without first calling validate_url(). The sibling load_url_image() in the same file (called from /images/edit) calls validate_url(data) first — that gate was added under GHSA-jgx9-jr5x-mvpv. The two functions handle structurally identical input (an attacker-or-server-supplied URL string) and should enforce the same SSRF gate as a matter of code hygiene.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24518 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/9/2026 **Status:** ✅ Merged **Merged:** 5/10/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `chore/get-image-data-validate-url-hardening` --- ### 📝 Commits (2) - [`20d54ad`](https://github.com/open-webui/open-webui/commit/20d54ad43ba7f15255ce19ddd91341195c040945) chore: add validate_url() to get_image_data() for cohort consistency hardening - [`f5ff199`](https://github.com/open-webui/open-webui/commit/f5ff199feab979f8638aa22a9750563d80e5ad86) chore: trim comment ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/images.py` (+2 -0) </details> ### 📄 Description `get_image_data()` in `backend/open_webui/routers/images.py` fetches the URL returned by the configured image generation API directly via `session.get(data)` without first calling `validate_url()`. The sibling `load_url_image()` in the same file (called from /images/edit) calls `validate_url(data)` first — that gate was added under GHSA-jgx9-jr5x-mvpv. The two functions handle structurally identical input (an attacker-or-server-supplied URL string) and should enforce the same SSRF gate as a matter of code hygiene. ### Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-13 17:07:29 -05:00

GiteaMirror closed this issue

2026-05-13 17:07:32 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#82574