[PR #4253] [MERGED] fix: Fix the SensitiveInput the browser thought it was a password field #8225

New Issue

GiteaMirror · 2025-11-11T17:48:10-06:00

GiteaMirror commented

2025-11-11 17:48:10 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/4253
Author: @erickgodev
Created: 7/31/2024
Status: ✅ Merged
Merged: 8/1/2024
Merged by: @tjbck

Base: dev ← Head: fix-SensitiveInput-for-admin-pages

📝 Commits (2)

3569fe9 the fix for the issue where chrome thought the SensitiveInput input was a password field
c44e51a refac

📊 Changes

2 files changed (+6 additions, -2 deletions)

View changed files

📝 src/app.css (+4 -0)
📝 src/lib/components/common/SensitiveInput.svelte (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixed the SensitiveInput component so that Chrome does not mistakenly recognize inputs as passwords.

Changed

SensitiveInput now uses -webkit-text-security: disc instead of type=password, causing the browser to not recognize the field as a password.

Additional Information

I've already checked, -webkit-text-security works with all browsers from the last 4 years, and Open WebUI itself doesn't work in a version so old that -webkit-text-security isn't supported. I tested it.

Screenshots or Videos

Before

https://github.com/user-attachments/assets/a516daa0-4f06-431b-b739-2368a119a608

After

https://github.com/user-attachments/assets/da82e099-3eae-4c87-b1fb-d887d2561cbe

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/4253 **Author:** [@erickgodev](https://github.com/erickgodev) **Created:** 7/31/2024 **Status:** ✅ Merged **Merged:** 8/1/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-SensitiveInput-for-admin-pages` --- ### 📝 Commits (2) - [`3569fe9`](https://github.com/open-webui/open-webui/commit/3569fe9c73d7a206212bcb4311be5a9b9a5674d9) the fix for the issue where chrome thought the SensitiveInput input was a password field - [`c44e51a`](https://github.com/open-webui/open-webui/commit/c44e51ae58e694d2042a65a0d2f566fc56ef3876) refac ### 📊 Changes **2 files changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/app.css` (+4 -0) 📝 `src/lib/components/common/SensitiveInput.svelte` (+2 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixed the `SensitiveInput` component so that Chrome does not mistakenly recognize inputs as passwords. ### Changed - `SensitiveInput` now uses `-webkit-text-security: disc` instead of `type=password`, causing the browser to not recognize the field as a password. --- ### Additional Information - I've already checked, `-webkit-text-security` works with all browsers from the last 4 years, and Open WebUI itself doesn't work in a version so old that `-webkit-text-security` isn't supported. I tested it. ### Screenshots or Videos #### Before https://github.com/user-attachments/assets/a516daa0-4f06-431b-b739-2368a119a608 #### After https://github.com/user-attachments/assets/da82e099-3eae-4c87-b1fb-d887d2561cbe --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 17:48:10 -06:00

GiteaMirror closed this issue

2025-11-11 17:48:10 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#8225