[PR #23572] [MERGED] fix: honor REDIS_SOCKET_CONNECT_TIMEOUT on non-sentinel clients #82130

Closed
opened 2026-05-13 16:35:30 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23572
Author: @Classic298
Created: 4/10/2026
Status: Merged
Merged: 4/11/2026
Merged by: @tjbck

Base: devHead: claude/redis-socket-connect-timeout


📝 Commits (2)

  • 65136e2 fix(redis): honor REDIS_SOCKET_CONNECT_TIMEOUT on non-sentinel clients
  • 3bb72a7 fix(redis): gate socket_connect_timeout on is-not-None, not truthiness

📊 Changes

1 file changed (+26 additions, -4 deletions)

View changed files

📝 backend/open_webui/utils/redis.py (+26 -4)

📄 Description

Previously only the sentinel path passed REDIS_SOCKET_CONNECT_TIMEOUT through to the Redis client. Plain redis:// and cluster URLs fell back to redis-py's default (no explicit connect timeout), so a hung Redis or a black-holed network path could stall the whole worker until the kernel gave up. Forwarding the same env var to from_url()/RedisCluster keeps the behavior consistent across all deployment topologies.

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23572 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/10/2026 **Status:** ✅ Merged **Merged:** 4/11/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `claude/redis-socket-connect-timeout` --- ### 📝 Commits (2) - [`65136e2`](https://github.com/open-webui/open-webui/commit/65136e2d75a2a412aa1272547742f3fa8fad81d2) fix(redis): honor REDIS_SOCKET_CONNECT_TIMEOUT on non-sentinel clients - [`3bb72a7`](https://github.com/open-webui/open-webui/commit/3bb72a7a02d0fd0f0012ed5b78f1adfed15d7824) fix(redis): gate socket_connect_timeout on is-not-None, not truthiness ### 📊 Changes **1 file changed** (+26 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/redis.py` (+26 -4) </details> ### 📄 Description Previously only the sentinel path passed REDIS_SOCKET_CONNECT_TIMEOUT through to the Redis client. Plain redis:// and cluster URLs fell back to redis-py's default (no explicit connect timeout), so a hung Redis or a black-holed network path could stall the whole worker until the kernel gave up. Forwarding the same env var to from_url()/RedisCluster keeps the behavior consistent across all deployment topologies. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-13 16:35:30 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#82130