[PR #3631] [MERGED] feat: Custom Collapsible component #8101

Closed
opened 2025-11-11 17:45:02 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/3631
Author: @ricky-davis
Created: 7/4/2024
Status: Merged
Merged: 7/6/2024
Merged by: @tjbck

Base: devHead: CustomCollapsible


📝 Commits (7)

  • d20601d feat: Add custom Collapsible component for collapsible content
  • 2389c36 refactor: Update WebSearchResults.svelte to use new CollapsibleComponent
  • d5c0876 refactor: fixed new Collapsible Component to allow passed in classes
  • db58bb5 refactor: Removed dependency
  • 78ba18a refactor: Update Collapsible component to include dynamic margin for open state
  • ca3f8e6 chore: format
  • 73899e1 refac

📊 Changes

2 files changed (+33 additions, -22 deletions)

View changed files

📝 src/lib/components/chat/Messages/ResponseMessage/WebSearchResults.svelte (+15 -22)
src/lib/components/common/Collapsible.svelte (+18 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Provides a custom built collapsible component which can be used instead of the bits-ui provided component. The bits-ui component causes page crashing when the component is opened/closed while the content is still being modified.

Added

  • New custom Collapsible component.

Changed

  • Updated WebSearchResults to use new Collapsible component.

Fixed

  • Fixes issue with opening/closing collapsible while content is still being modified.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/3631 **Author:** [@ricky-davis](https://github.com/ricky-davis) **Created:** 7/4/2024 **Status:** ✅ Merged **Merged:** 7/6/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `CustomCollapsible` --- ### 📝 Commits (7) - [`d20601d`](https://github.com/open-webui/open-webui/commit/d20601dc475034d51a7617ba9ceedb84fdbacabf) feat: Add custom Collapsible component for collapsible content - [`2389c36`](https://github.com/open-webui/open-webui/commit/2389c36a70d55ee6da4164b9e085a322e488a194) refactor: Update WebSearchResults.svelte to use new CollapsibleComponent - [`d5c0876`](https://github.com/open-webui/open-webui/commit/d5c0876a0b180cfc413a7dfb55ae4fe34f2f5d52) refactor: fixed new Collapsible Component to allow passed in classes - [`db58bb5`](https://github.com/open-webui/open-webui/commit/db58bb5f0f51521fa5c52e1b4e8107e6275904ad) refactor: Removed dependency - [`78ba18a`](https://github.com/open-webui/open-webui/commit/78ba18a680f9cce4c895279282ecf60fc581f382) refactor: Update Collapsible component to include dynamic margin for open state - [`ca3f8e6`](https://github.com/open-webui/open-webui/commit/ca3f8e6cb52231a21f7c157fd1e38504665b1793) chore: format - [`73899e1`](https://github.com/open-webui/open-webui/commit/73899e1c0d09981d6897ec2e321c5fa0aa535b77) refac ### 📊 Changes **2 files changed** (+33 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/ResponseMessage/WebSearchResults.svelte` (+15 -22) ➕ `src/lib/components/common/Collapsible.svelte` (+18 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Provides a custom built collapsible component which can be used instead of the bits-ui provided component. The bits-ui component causes page crashing when the component is opened/closed while the content is still being modified. ### Added - New custom Collapsible component. ### Changed - Updated WebSearchResults to use new Collapsible component. ### Fixed - Fixes issue with opening/closing collapsible while content is still being modified. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:45:02 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#8101