[PR #3499] [MERGED] fix: First OIDC account is not admin #8053

Closed
opened 2025-11-11 17:43:47 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/3499
Author: @Semihal
Created: 6/28/2024
Status: Merged
Merged: 6/29/2024
Merged by: @tjbck

Base: devHead: fix-oauth-openid


📝 Commits (6)

  • 1eebb85 Merge pull request #3323 from open-webui/dev
  • b072481 Merge pull request #3477 from open-webui/dev
  • f7da94f Merge pull request #3485 from open-webui/dev
  • 24b638f Merge pull request #3486 from open-webui/dev
  • 57c3305 Fix: admin role for OIDC signup for first user
  • 7d10dac Fix: set jwt_token to cookie (instead of token from OIDC)

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 backend/main.py (+7 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • FIX errors with auth through OIDC (openid).

Fixed

  • #3496 First user with OIDC (openid) provider is not admin.
  • Write full openid information to cookie, instead of jwt_token.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/3499 **Author:** [@Semihal](https://github.com/Semihal) **Created:** 6/28/2024 **Status:** ✅ Merged **Merged:** 6/29/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-oauth-openid` --- ### 📝 Commits (6) - [`1eebb85`](https://github.com/open-webui/open-webui/commit/1eebb85f4884a239e0f25fa0df6a767ef9311ed3) Merge pull request #3323 from open-webui/dev - [`b072481`](https://github.com/open-webui/open-webui/commit/b0724811dfdb70883c112c20e05dda46707e0330) Merge pull request #3477 from open-webui/dev - [`f7da94f`](https://github.com/open-webui/open-webui/commit/f7da94ff857c33cf8bd436639f80eecd8c21d6ae) Merge pull request #3485 from open-webui/dev - [`24b638f`](https://github.com/open-webui/open-webui/commit/24b638fcdea17fb8621e0391150bee852cf74a38) Merge pull request #3486 from open-webui/dev - [`57c3305`](https://github.com/open-webui/open-webui/commit/57c330576d35ead07e8c8086e4fd05f697037ddf) Fix: admin role for OIDC signup for first user - [`7d10dac`](https://github.com/open-webui/open-webui/commit/7d10dacad68b08c3164c10a8b0ccb80cf39a4bb7) Fix: set jwt_token to cookie (instead of token from OIDC) ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/main.py` (+7 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - FIX errors with auth through OIDC (openid). ### Fixed - #3496 First user with OIDC (openid) provider is not admin. - Write full openid information to cookie, instead of jwt_token. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:43:47 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#8053