[PR #20459] [MERGED] fix(channels): eliminate N+1 query in get_pinned_messages endpoint #80505

New Issue

GiteaMirror · 2026-05-13T14:37:30-05:00

GiteaMirror commented

2026-05-13 14:37:30 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20459
Author: @Classic298
Created: 1/7/2026
Status: ✅ Merged
Merged: 1/7/2026
Merged by: @tjbck

Base: dev ← Head: channel-perf-2

📝 Commits (1)

85afef5 fix(channels): eliminate N+1 query in get_pinned_messages endpoint

📊 Changes

1 file changed (+7 additions, -5 deletions)

View changed files

📝 backend/open_webui/routers/channels.py (+7 -5)

📄 Description

Replaced per-message user lookup with batch fetch using SQL IN clause.

Changes:

Fetch all message user_ids in a single pass
Use Users.get_users_by_user_ids() for batch lookup
Build user mapping to avoid DB calls in loop
Add early return for empty message lists

Performance: Reduces N+1 queries to 2 queries (messages + users)

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20459 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 1/7/2026 **Status:** ✅ Merged **Merged:** 1/7/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `channel-perf-2` --- ### 📝 Commits (1) - [`85afef5`](https://github.com/open-webui/open-webui/commit/85afef5a5d7318724b10d3063264f0f4b87a9660) fix(channels): eliminate N+1 query in get_pinned_messages endpoint ### 📊 Changes **1 file changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/channels.py` (+7 -5) </details> ### 📄 Description Replaced per-message user lookup with batch fetch using SQL IN clause. Changes: - Fetch all message user_ids in a single pass - Use Users.get_users_by_user_ids() for batch lookup - Build user mapping to avoid DB calls in loop - Add early return for empty message lists Performance: Reduces N+1 queries to 2 queries (messages + users) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-13 14:37:30 -05:00

GiteaMirror closed this issue

2026-05-13 14:37:32 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#80505