[PR #3417] [MERGED] feat: Added delete confirmation dialogs for Prompts, Tools, and Functions. #8036

Closed
opened 2025-11-11 17:43:23 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/3417
Author: @ricky-davis
Created: 6/25/2024
Status: Merged
Merged: 6/25/2024
Merged by: @tjbck

Base: devHead: addDeleteConfirmationToolsFunctions


📝 Commits (2)

  • 263d4bf Added delete confirmation dialogs for Prompts, Tools, and Functions.
  • 4d5e161 Updated Functions and Tools to use existing selected* Variable

📊 Changes

3 files changed (+52 additions, -3 deletions)

View changed files

📝 src/lib/components/workspace/Functions.svelte (+17 -1)
📝 src/lib/components/workspace/Prompts.svelte (+18 -1)
📝 src/lib/components/workspace/Tools.svelte (+17 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Partially addresses https://github.com/open-webui/open-webui/issues/2607

  • Adds confirmation dialogs to prevent accidental deletion of important custom workspace items.

Added

  • Adds delete confirmation dialogs to the deletion process for Prompts, Tools, and Functions.

Additional Information

  • Future enhancements can be:
    • Standardizing the model deletion prompt with this or vice/versa
    • Adding shift+click to delete without confirmation prompt

Screenshots or Videos

image image image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/3417 **Author:** [@ricky-davis](https://github.com/ricky-davis) **Created:** 6/25/2024 **Status:** ✅ Merged **Merged:** 6/25/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `addDeleteConfirmationToolsFunctions` --- ### 📝 Commits (2) - [`263d4bf`](https://github.com/open-webui/open-webui/commit/263d4bf49643e391b296082aa207e8e436c49075) Added delete confirmation dialogs for Prompts, Tools, and Functions. - [`4d5e161`](https://github.com/open-webui/open-webui/commit/4d5e161a3e0305faef2c6b1c6d30afe7004bd22e) Updated Functions and Tools to use existing selected* Variable ### 📊 Changes **3 files changed** (+52 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/workspace/Functions.svelte` (+17 -1) 📝 `src/lib/components/workspace/Prompts.svelte` (+18 -1) 📝 `src/lib/components/workspace/Tools.svelte` (+17 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Partially addresses https://github.com/open-webui/open-webui/issues/2607 - Adds confirmation dialogs to prevent accidental deletion of important custom workspace items. ### Added - Adds delete confirmation dialogs to the deletion process for Prompts, Tools, and Functions. --- ### Additional Information - Future enhancements can be: - Standardizing the model deletion prompt with this or vice/versa - Adding shift+click to delete without confirmation prompt ### Screenshots or Videos <img width="391" alt="image" src="https://github.com/open-webui/open-webui/assets/48695279/1574cfee-eaa7-46bc-a57f-31053f30b05c"> <img width="398" alt="image" src="https://github.com/open-webui/open-webui/assets/48695279/d0209f04-bd4d-4b3d-9b4f-e80a441ee60c"> <img width="412" alt="image" src="https://github.com/open-webui/open-webui/assets/48695279/3dcda925-5438-4ac0-9255-388efac71606"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:43:23 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#8036