[PR #3219] [MERGED] feat: added support for Stable Diffusion 3 alongside more extensive ComfyUI configuration #8005

New Issue

GiteaMirror · 2025-11-11T17:42:23-06:00

GiteaMirror commented

2025-11-11 17:42:23 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/3219
Author: @JohnTheNerd
Created: 6/16/2024
Status: ✅ Merged
Merged: 6/16/2024
Merged by: @tjbck

Base: dev ← Head: comfyui-configuration

📝 Commits (1)

ea074fa added Stable Diffusion 3 support alongside ComfyUI configuration

📊 Changes

3 files changed (+60 additions, -1 deletions)

View changed files

📝 backend/apps/images/main.py (+20 -0)
📝 backend/apps/images/utils/comfyui.py (+16 -1)
📝 backend/config.py (+24 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

added Stable Diffusion 3 support alongside ComfyUI configuration.

this commit adds four environment variables:

COMFYUI_CFG_SCALE
COMFYUI_SAMPLER
COMFYUI_SCHEDULER
COMFYUI_SD3

Added

The above mentioned environment variables, alongside Stable Diffusion 3 support.

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

closes #1459 alongside addressing the top comment (for ComfyUI only, as I do not have an AUTOMATIC1111 setup to test with). also closes #1958 (again, for ComfyUI only, since afaik AUTOMATIC1111 doesn't even support SD3).

Security

N/A

Breaking Changes

No breaking changes, because if the environment variable does not exist, we fall back to the original behavior.

Additional Information

All three of the changes I wrote in the past few hours are built together in the Docker image ghcr.io/johnthenerd/open-webui:comfyui-test3 and I am currently running them in my homelab without any issues. Tested with and without the new environment variables.

Docs at https://github.com/open-webui/docs/pull/119

Screenshots or Videos

SD3 with everything set to what is recommended in the documentation (updated the example screenshot since the last PR, because this is so much nicer):

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/3219 **Author:** [@JohnTheNerd](https://github.com/JohnTheNerd) **Created:** 6/16/2024 **Status:** ✅ Merged **Merged:** 6/16/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `comfyui-configuration` --- ### 📝 Commits (1) - [`ea074fa`](https://github.com/open-webui/open-webui/commit/ea074fa9bfb6d9f5dac516de81599b3a638ae067) added Stable Diffusion 3 support alongside ComfyUI configuration ### 📊 Changes **3 files changed** (+60 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/apps/images/main.py` (+20 -0) 📝 `backend/apps/images/utils/comfyui.py` (+16 -1) 📝 `backend/config.py` (+24 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description added Stable Diffusion 3 support alongside ComfyUI configuration. this commit adds four environment variables: - COMFYUI_CFG_SCALE - COMFYUI_SAMPLER - COMFYUI_SCHEDULER - COMFYUI_SD3 ### Added The above mentioned environment variables, alongside Stable Diffusion 3 support. ### Changed N/A ### Deprecated N/A ### Removed N/A ### Fixed closes #1459 alongside addressing the top comment (for ComfyUI only, as I do not have an AUTOMATIC1111 setup to test with). also closes #1958 (again, for ComfyUI only, since afaik AUTOMATIC1111 doesn't even support SD3). ### Security N/A ### Breaking Changes No breaking changes, because if the environment variable does not exist, we fall back to the original behavior. --- ### Additional Information All three of the changes I wrote in the past few hours are built together in the Docker image `ghcr.io/johnthenerd/open-webui:comfyui-test3` and I am currently running them in my homelab without any issues. Tested with and without the new environment variables. Docs at https://github.com/open-webui/docs/pull/119 ### Screenshots or Videos SD3 with everything set to what is recommended in the documentation (updated the example screenshot since the last PR, because this is so much nicer): ![image](https://github.com/open-webui/open-webui/assets/9657143/3b9c6ca7-3004-4b27-a15a-3025076ed4f4) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 17:42:23 -06:00

GiteaMirror closed this issue

2025-11-11 17:42:24 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#8005