[PR #17421] [CLOSED] fix: Return usage information correctly for google models #79295

New Issue

GiteaMirror · 2026-05-13T13:06:31-05:00

GiteaMirror commented

2026-05-13 13:06:31 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17421
Author: @aleprj
Created: 9/13/2025
Status: ❌ Closed

Base: dev ← Head: fix-usage-google

📝 Commits (2)

f2e8867 fix: don't assume usage is sent only when there is no delta. Some providers will send everything together.
000ca48 fix errors in the logic.

📊 Changes

1 file changed (+16 additions, -14 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+16 -14)

📄 Description

…viders will send everything together.

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

While streaming the response from a model, we assumed that the usage information would be sent only after all the delta content, in a separate interation, as OpenAI usually does. Some providers send the data together with the last chunk of data tough, so the usage information would be lost.

Added

Changed

Deprecated

Removed

Fixed

An issue was resolved that prevented usage data from being correctly collected in some cases.

Security

Breaking Changes

Additional Information

The code assumed the usage information would be always sent by the provider separated from the choices tag (as OpenAI usually does). But Google often just sends everything together when the generation is small:
{ "choices": [ { "delta": { "content": "Olá! Como posso ajudar?", "role": "assistant" }, "finish_reason": "stop", "index": 0 } ], "created": 1757736622, "id": "ru7EaIjuDKWgz7IP48a6kAM", "model": "gemini-2.5-flash", "object": "chat.completion.chunk", "usage": { "completion_tokens": 6, "prompt_tokens": 3, "total_tokens": 41 } }

Even when it's big, it sends the usage with every iteration, updating the token values as it goes. The last iteration contains both the last chunk and the last usage information.

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

It's a simple fix but It's important for people that use filters to register the usage with langfuse or other tools.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17421 **Author:** [@aleprj](https://github.com/aleprj) **Created:** 9/13/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix-usage-google` --- ### 📝 Commits (2) - [`f2e8867`](https://github.com/open-webui/open-webui/commit/f2e886771d7845244d9427efd22faf66245a6146) fix: don't assume usage is sent only when there is no delta. Some providers will send everything together. - [`000ca48`](https://github.com/open-webui/open-webui/commit/000ca48936c5dbfa48084f06a9785424af55c79b) fix errors in the logic. ### 📊 Changes **1 file changed** (+16 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+16 -14) </details> ### 📄 Description …viders will send everything together. # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - While streaming the response from a model, we assumed that the usage information would be sent only after all the delta content, in a separate interation, as OpenAI usually does. Some providers send the data together with the last chunk of data tough, so the usage information would be lost. ### Added ### Changed ### Deprecated ### Removed ### Fixed - An issue was resolved that prevented usage data from being correctly collected in some cases. ### Security ### Breaking Changes ### Additional Information The code assumed the usage information would be always sent by the provider separated from the choices tag (as OpenAI usually does). But Google often just sends everything together when the generation is small: `{ "choices": [ { "delta": { "content": "Olá! Como posso ajudar?", "role": "assistant" }, "finish_reason": "stop", "index": 0 } ], "created": 1757736622, "id": "ru7EaIjuDKWgz7IP48a6kAM", "model": "gemini-2.5-flash", "object": "chat.completion.chunk", "usage": { "completion_tokens": 6, "prompt_tokens": 3, "total_tokens": 41 } }` Even when it's big, it sends the usage with every iteration, updating the token values as it goes. The last iteration contains both the last chunk and the last usage information. ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. It's a simple fix but It's important for people that use filters to register the usage with langfuse or other tools. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-13 13:06:31 -05:00

GiteaMirror closed this issue

2026-05-13 13:06:34 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#79295