github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-03-10 15:54:15 -05:00
Code Issues 308 Packages Projects Releases 100 Wiki Activity

[PR #2812] [CLOSED] feat: show warning for deleted files context #7905

New Issue
Closed
opened 2025-11-11 17:39:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 17:39:48 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/2812
Author: @jonathan-rohde
Created: 6/4/2024
Status: ❌ Closed

Base: dev ← Head: feat/show-warning-for-deleted-files-context

📝 Commits (7)

  • 3c97fa5 feat(chat): show warning for missing documents
  • c3944f4 feat(chat): add en_gb, en_us and de translation
  • b26267b feat(chat): make test independent of underlying llm
  • 0a1d633 feat(chat): add e2e test
  • 50837bc feat(chat): revert unintended config changes
  • 0179204 feat(chat): formatting
  • 1fb6510 feat(chat): add placeholder translation entries

📊 Changes

45 files changed (+392 additions, -18 deletions)

View changed files

📝 backend/apps/rag/utils.py (+9 -6)
📝 backend/main.py (+16 -5)
➕ cypress/data/example-doc.txt (+9 -0)
📝 cypress/e2e/chat.cy.ts (+115 -4)
📝 src/lib/apis/streaming/index.ts (+5 -0)
📝 src/lib/components/chat/Chat.svelte (+11 -1)
📝 src/lib/components/chat/Messages/ResponseMessage.svelte (+10 -0)
📝 src/lib/components/common/Tags/TagInput.svelte (+2 -1)
📝 src/lib/components/documents/Settings/General.svelte (+2 -0)
📝 src/lib/components/workspace/Documents.svelte (+3 -1)
📝 src/lib/i18n/locales/ar-BH/translation.json (+6 -0)
📝 src/lib/i18n/locales/bg-BG/translation.json (+6 -0)
📝 src/lib/i18n/locales/bn-BD/translation.json (+6 -0)
📝 src/lib/i18n/locales/ca-ES/translation.json (+6 -0)
📝 src/lib/i18n/locales/ceb-PH/translation.json (+6 -0)
📝 src/lib/i18n/locales/de-DE/translation.json (+6 -0)
📝 src/lib/i18n/locales/dg-DG/translation.json (+6 -0)
📝 src/lib/i18n/locales/en-GB/translation.json (+6 -0)
📝 src/lib/i18n/locales/en-US/translation.json (+6 -0)
📝 src/lib/i18n/locales/es-ES/translation.json (+6 -0)

...and 25 more files

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Label: To cleary categorize this pull request, assign a relevant label to the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Once a document has been removed from the vector database, the context is compromised and chat messages either result in an invalid/wrong answer or the LLM will just reply with "I don't know"

Added

  • Warning to each chat response from LLM, if at least one document checksum was not found in vector database

Screenshots or Videos

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/2812 **Author:** [@jonathan-rohde](https://github.com/jonathan-rohde) **Created:** 6/4/2024 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feat/show-warning-for-deleted-files-context` --- ### 📝 Commits (7) - [`3c97fa5`](https://github.com/open-webui/open-webui/commit/3c97fa558dde04ec7fbbb8f77ef38eb3ce8b86f9) feat(chat): show warning for missing documents - [`c3944f4`](https://github.com/open-webui/open-webui/commit/c3944f4fe5b269401b1fc3423081be1486893210) feat(chat): add en_gb, en_us and de translation - [`b26267b`](https://github.com/open-webui/open-webui/commit/b26267bbe0077724535d8bc594ebbf3cd36af2df) feat(chat): make test independent of underlying llm - [`0a1d633`](https://github.com/open-webui/open-webui/commit/0a1d633034c033164c76b6b9874707c392e8df5b) feat(chat): add e2e test - [`50837bc`](https://github.com/open-webui/open-webui/commit/50837bc227265f67d20c4d5d828b17ca6bd2deca) feat(chat): revert unintended config changes - [`0179204`](https://github.com/open-webui/open-webui/commit/0179204847df5b2aae29b8c791eab676a3ff123a) feat(chat): formatting - [`1fb6510`](https://github.com/open-webui/open-webui/commit/1fb6510e9062049f2e5c268d54ced4e9c510db51) feat(chat): add placeholder translation entries ### 📊 Changes **45 files changed** (+392 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `backend/apps/rag/utils.py` (+9 -6) 📝 `backend/main.py` (+16 -5) ➕ `cypress/data/example-doc.txt` (+9 -0) 📝 `cypress/e2e/chat.cy.ts` (+115 -4) 📝 `src/lib/apis/streaming/index.ts` (+5 -0) 📝 `src/lib/components/chat/Chat.svelte` (+11 -1) 📝 `src/lib/components/chat/Messages/ResponseMessage.svelte` (+10 -0) 📝 `src/lib/components/common/Tags/TagInput.svelte` (+2 -1) 📝 `src/lib/components/documents/Settings/General.svelte` (+2 -0) 📝 `src/lib/components/workspace/Documents.svelte` (+3 -1) 📝 `src/lib/i18n/locales/ar-BH/translation.json` (+6 -0) 📝 `src/lib/i18n/locales/bg-BG/translation.json` (+6 -0) 📝 `src/lib/i18n/locales/bn-BD/translation.json` (+6 -0) 📝 `src/lib/i18n/locales/ca-ES/translation.json` (+6 -0) 📝 `src/lib/i18n/locales/ceb-PH/translation.json` (+6 -0) 📝 `src/lib/i18n/locales/de-DE/translation.json` (+6 -0) 📝 `src/lib/i18n/locales/dg-DG/translation.json` (+6 -0) 📝 `src/lib/i18n/locales/en-GB/translation.json` (+6 -0) 📝 `src/lib/i18n/locales/en-US/translation.json` (+6 -0) 📝 `src/lib/i18n/locales/es-ES/translation.json` (+6 -0) _...and 25 more files_ </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Label:** To cleary categorize this pull request, assign a relevant label to the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Once a document has been removed from the vector database, the context is compromised and chat messages either result in an invalid/wrong answer or the LLM will just reply with "I don't know" ### Added - Warning to each chat response from LLM, if at least one document checksum was not found in vector database --- ### Screenshots or Videos ![image](https://github.com/open-webui/open-webui/assets/165899591/a4ba54f6-a16c-49f4-92c7-a52d0da75cc2) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:39:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#7905
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?