[PR #12602] [MERGED] fix: mismatch between TOOL_SERVERS / TOOL_SERVER_CONNECTIONS indexing #77857

New Issue

GiteaMirror · 2026-05-13T11:24:53-05:00

GiteaMirror commented

2026-05-13 11:24:53 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/12602
Author: @tremlin
Created: 4/8/2025
Status: ✅ Merged
Merged: 4/10/2025
Merged by: @tjbck

Base: dev ← Head: fix-tool-server-indexing-mismatch

📝 Commits (1)

f5b2867 fix: mismatch between TOOL_SERVERS / TOOL_SERVER_CONNECTIONS indexing

📊 Changes

2 files changed (+8 additions, -3 deletions)

View changed files

📝 backend/open_webui/routers/tools.py (+2 -2)
📝 backend/open_webui/utils/tools.py (+6 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

When global tool servers are disabled, some pieces of code don't work correctly. Using the tool in a chat can fail and the access control for tools might be wrong.

Added

Changed

Deprecated

Removed

Fixed

Fix issue with wrong behavior with disabled global tool servers.

Security

Breaking Changes

Additional Information

When a tool server is disabled, the lists TOOL_SERVERS and TOOL_SERVER_CONNECTIONS have different indexes. This is not accounted for correctly everywhere.
This causes several problems. One of them is that the user gets an error message in chat when there are two tool servers, the first one is disabled, and the second one is being used in chat.

An alternative solution would be to convert TOOL_SERVERS to a dict with the server index as key. Not sure which solution you prefer.

Screenshots or Videos

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/12602 **Author:** [@tremlin](https://github.com/tremlin) **Created:** 4/8/2025 **Status:** ✅ Merged **Merged:** 4/10/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-tool-server-indexing-mismatch` --- ### 📝 Commits (1) - [`f5b2867`](https://github.com/open-webui/open-webui/commit/f5b2867e458e644ec5a8402848055dba04266763) fix: mismatch between TOOL_SERVERS / TOOL_SERVER_CONNECTIONS indexing ### 📊 Changes **2 files changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/tools.py` (+2 -2) 📝 `backend/open_webui/utils/tools.py` (+6 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - When global tool servers are disabled, some pieces of code don't work correctly. Using the tool in a chat can fail and the access control for tools might be wrong. ### Added ### Changed ### Deprecated ### Removed ### Fixed - Fix issue with wrong behavior with disabled global tool servers. ### Security ### Breaking Changes --- ### Additional Information When a tool server is disabled, the lists `TOOL_SERVERS` and `TOOL_SERVER_CONNECTIONS` have different indexes. This is not accounted for correctly everywhere. This causes several problems. One of them is that the user gets an error message in chat when there are two tool servers, the first one is disabled, and the second one is being used in chat. An alternative solution would be to convert `TOOL_SERVERS` to a dict with the server index as key. Not sure which solution you prefer. ### Screenshots or Videos --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-13 11:24:53 -05:00

GiteaMirror closed this issue

2026-05-13 11:24:56 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#77857