a506a1a only keep URLs as sources for which the content could actually be retrieved
📊 Changes
1 file changed (+1 additions, -0 deletions)
View changed files
📝backend/open_webui/routers/retrieval.py (+1 -0)
📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
When processing web search results, the list of source URLs was inferred just from the web search results. That means if retrieval of any result URL would fail, there was no document for that URL, but the URL was kept in the list. In effect, there was a mismatch between list of documents and list of URLs.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/12517
**Author:** [@Ithanil](https://github.com/Ithanil)
**Created:** 4/6/2025
**Status:** ✅ Merged
**Merged:** 4/6/2025
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `only_keep_retrieved_urls`
---
### 📝 Commits (1)
- [`a506a1a`](https://github.com/open-webui/open-webui/commit/a506a1a61ed05ad2d06a3fb0d716c6b0684359c8) only keep URLs as sources for which the content could actually be retrieved
### 📊 Changes
**1 file changed** (+1 additions, -0 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/routers/retrieval.py` (+1 -0)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [x] **Testing:** Have you written and run sufficient tests to validate the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
When processing web search results, the list of source URLs was inferred just from the web search results. That means if retrieval of any result URL would fail, there was no document for that URL, but the URL was kept in the list. In effect, there was a mismatch between list of documents and list of URLs.
With the present PR, the final list of URLs is inferred from the document metadata (which all loaders in https://github.com/open-webui/open-webui/blob/dev/backend/open_webui/retrieval/web/utils.py set correctly as ` metadata = {"source": url}`), ensuring a 1:1 match.
### Fixed
- URL list inferred from document metadata
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/12517
Author: @Ithanil
Created: 4/6/2025
Status: ✅ Merged
Merged: 4/6/2025
Merged by: @tjbck
Base:
dev← Head:only_keep_retrieved_urls📝 Commits (1)
a506a1aonly keep URLs as sources for which the content could actually be retrieved📊 Changes
1 file changed (+1 additions, -0 deletions)
View changed files
📝
backend/open_webui/routers/retrieval.py(+1 -0)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
When processing web search results, the list of source URLs was inferred just from the web search results. That means if retrieval of any result URL would fail, there was no document for that URL, but the URL was kept in the list. In effect, there was a mismatch between list of documents and list of URLs.
With the present PR, the final list of URLs is inferred from the document metadata (which all loaders in https://github.com/open-webui/open-webui/blob/dev/backend/open_webui/retrieval/web/utils.py set correctly as
metadata = {"source": url}), ensuring a 1:1 match.Fixed
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.