[PR #10755] [MERGED] Conditional import of ldap3 and chromadb #77461

New Issue

GiteaMirror · 2026-05-13T10:53:51-05:00

GiteaMirror commented

2026-05-13 10:53:51 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10755
Author: @softue
Created: 2/25/2025
Status: ✅ Merged
Merged: 2/26/2025
Merged by: @tjbck

Base: dev ← Head: check-if-enable-ldap-chroma

📝 Commits (2)

b52a7e3 refac: conditional import of chromadb
2298bfb refac: conditional import of ldap3

📊 Changes

2 files changed (+23 additions, -19 deletions)

View changed files

📝 backend/open_webui/config.py (+18 -17)
📝 backend/open_webui/routers/auths.py (+5 -2)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Conditional import of ldap3 and chromadb.

Changed

Check VECTOR_DB var before chromadb import.
Check ENABLE_LDAP var before ldap3 import.

Additional Information

Import these libraries only if they are enabled.

Enabling ldap3 requires restarting the server.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10755 **Author:** [@softue](https://github.com/softue) **Created:** 2/25/2025 **Status:** ✅ Merged **Merged:** 2/26/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `check-if-enable-ldap-chroma` --- ### 📝 Commits (2) - [`b52a7e3`](https://github.com/open-webui/open-webui/commit/b52a7e354308010c1a3c0449f71b0b423ac06e17) refac: conditional import of chromadb - [`2298bfb`](https://github.com/open-webui/open-webui/commit/2298bfbd7e2373678e71eb03e8fea232c354573b) refac: conditional import of ldap3 ### 📊 Changes **2 files changed** (+23 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+18 -17) 📝 `backend/open_webui/routers/auths.py` (+5 -2) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Conditional import of ldap3 and chromadb. ### Changed Check VECTOR_DB var before chromadb import. Check ENABLE_LDAP var before ldap3 import. --- ### Additional Information Import these libraries only if they are enabled. Enabling ldap3 requires restarting the server. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-13 10:53:51 -05:00

GiteaMirror closed this issue

2026-05-13 10:53:53 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#77461