github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-03-22 14:13:08 -05:00
Code Issues 308 Packages Projects Releases 100 Wiki Activity

[PR #2264] [MERGED] fix: prevent loop when fetching shared chat id #7743

New Issue
Closed
opened 2025-11-11 17:34:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 17:34:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/2264
Author: @jonathan-rohde
Created: 5/14/2024
Status: ✅ Merged
Merged: 5/15/2024
Merged by: @tjbck

Base: dev ← Head: fix/share-chat-reactive-loop

📝 Commits (4)

  • 33b9629 fix: prevent loop when fetching shared chat id
  • ea6f1a0 Merge branch 'dev' into fix/share-chat-reactive-loop
  • 85dbdd2 Merge branch 'dev' into fix/share-chat-reactive-loop
  • 9381113 Update Menu.svelte

📊 Changes

4 files changed (+51 additions, -27 deletions)

View changed files

📝 cypress/e2e/chat.cy.ts (+33 -0)
📝 src/lib/components/chat/ShareChatModal.svelte (+15 -1)
📝 src/lib/components/layout/Navbar.svelte (+2 -1)
📝 src/lib/components/layout/Navbar/Menu.svelte (+1 -25)

📄 Description

Pull Request Checklist

  • Target branch: Pull requests should target the dev branch.
  • Description: Briefly describe the changes in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for the changes?
  • Code Review: Have you self-reviewed your code and addressed any coding standard issues?

Description

When you open the share modal dialog, the event loop causes a flood of requests to the backend. It is caused by the change of the variable chat, which cause a revalidate of the component and loading the same data again from backend.

Changelog Entry

Fixed

  • Request flood, when create the chat share link

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/2264 **Author:** [@jonathan-rohde](https://github.com/jonathan-rohde) **Created:** 5/14/2024 **Status:** ✅ Merged **Merged:** 5/15/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/share-chat-reactive-loop` --- ### 📝 Commits (4) - [`33b9629`](https://github.com/open-webui/open-webui/commit/33b9629164437f5e72d268aa0134114580b87ba5) fix: prevent loop when fetching shared chat id - [`ea6f1a0`](https://github.com/open-webui/open-webui/commit/ea6f1a0e571e0fc8a3c3ee734e8a7623e996dc60) Merge branch 'dev' into fix/share-chat-reactive-loop - [`85dbdd2`](https://github.com/open-webui/open-webui/commit/85dbdd23fc50a7419d036b5d92ca763912b4c0c9) Merge branch 'dev' into fix/share-chat-reactive-loop - [`9381113`](https://github.com/open-webui/open-webui/commit/9381113f6054af381a460ca9d08693cd7a39f090) Update Menu.svelte ### 📊 Changes **4 files changed** (+51 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `cypress/e2e/chat.cy.ts` (+33 -0) 📝 `src/lib/components/chat/ShareChatModal.svelte` (+15 -1) 📝 `src/lib/components/layout/Navbar.svelte` (+2 -1) 📝 `src/lib/components/layout/Navbar/Menu.svelte` (+1 -25) </details> ### 📄 Description ## Pull Request Checklist - [x] **Target branch:** Pull requests should target the `dev` branch. - [x] **Description:** Briefly describe the changes in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for the changes? - [x] **Code Review:** Have you self-reviewed your code and addressed any coding standard issues? --- ## Description When you open the share modal dialog, the event loop causes a flood of requests to the backend. It is caused by the change of the variable chat, which cause a revalidate of the component and loading the same data again from backend. --- ### Changelog Entry ### Fixed - Request flood, when create the chat share link --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:34:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#7743
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?