[PR #2186] [MERGED] fix: prettier scripts work on windows #7717

New Issue

GiteaMirror · 2025-11-11T17:34:06-06:00

GiteaMirror commented

2025-11-11 17:34:06 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/2186
Author: @cheahjs
Created: 5/11/2024
Status: ✅ Merged
Merged: 5/13/2024
Merged by: @tjbck

Base: dev ← Head: fix/windows-prettier

📝 Commits (2)

e3e037e fix: windows invocations of prettier
5506004 feat: add .gitignore to .prettierignore

📊 Changes

2 files changed (+304 additions, -8 deletions)

View changed files

📝 .prettierignore (+302 -6)
📝 package.json (+2 -2)

📄 Description

Pull Request Checklist

Target branch: Pull requests should target the dev branch.
Description: Briefly describe the changes in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for the changes?
Code Review: Have you self-reviewed your code and addressed any coding standard issues?

Description

Use double quotes for the prettier pattern to work with Windows (Powershell at least)
Add the contents of .gitignore into .prettierignore so we're not formatting the entirety of the python venv

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/2186 **Author:** [@cheahjs](https://github.com/cheahjs) **Created:** 5/11/2024 **Status:** ✅ Merged **Merged:** 5/13/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/windows-prettier` --- ### 📝 Commits (2) - [`e3e037e`](https://github.com/open-webui/open-webui/commit/e3e037e187e4f73a243d04e533eed693fc10abde) fix: windows invocations of prettier - [`5506004`](https://github.com/open-webui/open-webui/commit/55060045da6e8fbe5a9d161734a35e410cada946) feat: add .gitignore to .prettierignore ### 📊 Changes **2 files changed** (+304 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.prettierignore` (+302 -6) 📝 `package.json` (+2 -2) </details> ### 📄 Description ## Pull Request Checklist - [x] **Target branch:** Pull requests should target the `dev` branch. - [x] **Description:** Briefly describe the changes in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for the changes? - [ ] **Code Review:** Have you self-reviewed your code and addressed any coding standard issues? --- ## Description 1. Use double quotes for the prettier pattern to work with Windows (Powershell at least) 2. Add the contents of .gitignore into .prettierignore so we're not formatting the entirety of the python venv --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 17:34:06 -06:00

GiteaMirror closed this issue

2025-11-11 17:34:06 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#7717