github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-08 04:16:03 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #2182] [CLOSED] chore: address eslint errors #7715

New Issue
Closed
opened 2025-11-11 17:34:03 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 17:34:03 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/2182
Author: @cheahjs
Created: 5/11/2024
Status: ❌ Closed

Base: dev ← Head: fix/typescript-types

📝 Commits (7)

  • 1baba29 chore: add types for i18next usages
  • ac9ac8d chore: eslint --fix
  • 7f41074 chore: add sort-imports eslint rule
  • 58d0838 chore: add unused-imports eslint rule
  • 0840b60 chore: address all eslint errors
  • be89d12 fix: run i18next
  • 1a26280 Merge branch 'dev' into fix/typescript-types

📊 Changes

116 files changed (+677 additions, -752 deletions)

View changed files

📝 .eslintrc.cjs (+17 -2)
📝 package-lock.json (+38 -0)
📝 package.json (+2 -0)
📝 src/lib/apis/ollama/index.ts (+1 -1)
📝 src/lib/apis/users/index.ts (+14 -0)
📝 src/lib/apis/utils/index.ts (+6 -17)
📝 src/lib/components/AddFilesPlaceholder.svelte (+4 -2)
📝 src/lib/components/ChangelogModal.svelte (+5 -2)
📝 src/lib/components/admin/AddUserModal.svelte (+5 -15)
📝 src/lib/components/admin/EditUserModal.svelte (+5 -15)
📝 src/lib/components/admin/Settings/Database.svelte (+6 -3)
📝 src/lib/components/admin/Settings/General.svelte (+8 -5)
📝 src/lib/components/admin/Settings/Users.svelte (+6 -4)
📝 src/lib/components/admin/SettingsModal.svelte (+5 -2)
📝 src/lib/components/admin/UserChatsModal.svelte (+10 -8)
📝 src/lib/components/chat/MessageInput.svelte (+9 -18)
📝 src/lib/components/chat/MessageInput/Documents.svelte (+7 -4)
📝 src/lib/components/chat/MessageInput/Models.svelte (+7 -3)
📝 src/lib/components/chat/MessageInput/PromptCommands.svelte (+6 -2)
📝 src/lib/components/chat/MessageInput/Suggestions.svelte (+7 -4)

...and 80 more files

📄 Description

Pull Request Checklist

  • Target branch: Pull requests should target the dev branch.
  • Description: Briefly describe the changes in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for the changes?
  • Code Review: Have you self-reviewed your code and addressed any coding standard issues?

Description

  1. Address all eslint errors that are flagged when running npm run lint:frontend
  2. Add types for i18next usage across the codebase
  3. Add eslint-plugin-unused-imports to remove unused imports

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/2182 **Author:** [@cheahjs](https://github.com/cheahjs) **Created:** 5/11/2024 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/typescript-types` --- ### 📝 Commits (7) - [`1baba29`](https://github.com/open-webui/open-webui/commit/1baba2944803c326387e82abcbb6a6e6141f0010) chore: add types for i18next usages - [`ac9ac8d`](https://github.com/open-webui/open-webui/commit/ac9ac8d98f2e42feee07d16cf0802def063bcc65) chore: eslint --fix - [`7f41074`](https://github.com/open-webui/open-webui/commit/7f410747bbededbd3e29037d3764c42213580879) chore: add sort-imports eslint rule - [`58d0838`](https://github.com/open-webui/open-webui/commit/58d0838300b0ebe7a02f0ee38f514f53442dd746) chore: add unused-imports eslint rule - [`0840b60`](https://github.com/open-webui/open-webui/commit/0840b60bb86dedc74a0e30bfd627959af2e56e88) chore: address all eslint errors - [`be89d12`](https://github.com/open-webui/open-webui/commit/be89d123a57da65378eab0747cd329ac41d3d601) fix: run i18next - [`1a26280`](https://github.com/open-webui/open-webui/commit/1a2628061669e2e4306f1a696782c8163deb97ea) Merge branch 'dev' into fix/typescript-types ### 📊 Changes **116 files changed** (+677 additions, -752 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.cjs` (+17 -2) 📝 `package-lock.json` (+38 -0) 📝 `package.json` (+2 -0) 📝 `src/lib/apis/ollama/index.ts` (+1 -1) 📝 `src/lib/apis/users/index.ts` (+14 -0) 📝 `src/lib/apis/utils/index.ts` (+6 -17) 📝 `src/lib/components/AddFilesPlaceholder.svelte` (+4 -2) 📝 `src/lib/components/ChangelogModal.svelte` (+5 -2) 📝 `src/lib/components/admin/AddUserModal.svelte` (+5 -15) 📝 `src/lib/components/admin/EditUserModal.svelte` (+5 -15) 📝 `src/lib/components/admin/Settings/Database.svelte` (+6 -3) 📝 `src/lib/components/admin/Settings/General.svelte` (+8 -5) 📝 `src/lib/components/admin/Settings/Users.svelte` (+6 -4) 📝 `src/lib/components/admin/SettingsModal.svelte` (+5 -2) 📝 `src/lib/components/admin/UserChatsModal.svelte` (+10 -8) 📝 `src/lib/components/chat/MessageInput.svelte` (+9 -18) 📝 `src/lib/components/chat/MessageInput/Documents.svelte` (+7 -4) 📝 `src/lib/components/chat/MessageInput/Models.svelte` (+7 -3) 📝 `src/lib/components/chat/MessageInput/PromptCommands.svelte` (+6 -2) 📝 `src/lib/components/chat/MessageInput/Suggestions.svelte` (+7 -4) _...and 80 more files_ </details> ### 📄 Description ## Pull Request Checklist - [x] **Target branch:** Pull requests should target the `dev` branch. - [ ] **Description:** Briefly describe the changes in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for the changes? - [ ] **Code Review:** Have you self-reviewed your code and addressed any coding standard issues? --- ## Description 1. Address all eslint errors that are flagged when running `npm run lint:frontend` 2. Add types for `i18next` usage across the codebase 3. Add `eslint-plugin-unused-imports` to remove unused imports --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:34:03 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#7715
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?