mirror of
https://github.com/open-webui/open-webui.git
synced 2026-03-11 17:47:44 -05:00
bug: Settings modal should not close when dragging from inside of modal #760
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @domsleee on GitHub (Apr 29, 2024).
Bug Report
Description
The modal closes unexpectedly on
mouseupwhen dragging from inside the modal.For example, when highlighting text from within the modal,
mousedownis on the foreground andmouseupis on the backdrop. It should not close in this case:Expected Behavior:
In this case, the modal should stay open.
Actual Behavior:
The modal closes.
Environment
Open WebUI Version: 0.1.122
Ollama (if applicable): 0.1.32
Operating System: Windows 10
Browser (if applicable): Chrome
Confirmation:
Installation Method
Normal
dockerway:Suggested fix
It seems reasonable to follow the ChatGPT UI here and use the
mousedownevent instead of theclickevent.@justinh-rahb commented on GitHub (Apr 29, 2024):
I love it when people close their own issues with a PR 👍
Great contribution @domsleee, thank you! 🙏