github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #1435] [MERGED] feat: trigger docker build after release #7465

New Issue
Closed
opened 2025-11-11 17:27:16 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 17:27:16 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/1435
Author: @cheahjs
Created: 4/5/2024
Status: ✅ Merged
Merged: 4/7/2024
Merged by: @tjbck

Base: dev ← Head: fix/build-docker-tag

📝 Commits (1)

  • b7ced4e feat: trigger docker build after release

📊 Changes

2 files changed (+12 additions, -0 deletions)

View changed files

📝 .github/workflows/build-release.yml (+11 -0)
📝 .github/workflows/docker-build.yaml (+1 -0)

📄 Description

Pull Request Checklist

  • Description: Briefly describe the changes in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?

Description

Fixes the Docker workflow not building tagged images.

This was because releases are programatically created via GitHub Actions, and it is designed specifically such that any events originating from an action cannot trigger another action, as such the release action creating a new tag wasn't triggering the tagged Docker build (only the main branch build would have been triggered on push).

This fixes the inability to trigger by allowing the Docker workflow to be triggered by workflow_dispatch events, and the release workflow will manually trigger a tagged Docker build once it's done creating the release.

Test example:

This still isn't ideal, since Docker builds are triggered twice, and you end up with different Docker images for what is effectively the same underlying Git commit (main, git-<hash>, <tag> should all ideally point to the same image).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/1435 **Author:** [@cheahjs](https://github.com/cheahjs) **Created:** 4/5/2024 **Status:** ✅ Merged **Merged:** 4/7/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/build-docker-tag` --- ### 📝 Commits (1) - [`b7ced4e`](https://github.com/open-webui/open-webui/commit/b7ced4e4f1e236f8ca7b037dd1826bb984e3a212) feat: trigger docker build after release ### 📊 Changes **2 files changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-release.yml` (+11 -0) 📝 `.github/workflows/docker-build.yaml` (+1 -0) </details> ### 📄 Description ## Pull Request Checklist - [ ] **Description:** Briefly describe the changes in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? --- ## Description Fixes the Docker workflow not building tagged images. This was because releases are programatically created via GitHub Actions, and it is designed specifically such that any events originating from an action cannot trigger another action, as such the release action creating a new tag wasn't triggering the tagged Docker build (only the `main` branch build would have been triggered on push). This fixes the inability to trigger by allowing the Docker workflow to be triggered by `workflow_dispatch` events, and the release workflow will manually trigger a tagged Docker build once it's done creating the release. Test example: * Tagged Docker build: https://github.com/cheahjs/open-webui-fork/actions/runs/8574795311/job/23502387401 * <img width="473" alt="image" src="https://github.com/open-webui/open-webui/assets/818368/e0c7d248-e9a7-407c-b00f-71306bb4aee5"> * Release workflow triggering tagged Docker build: https://github.com/cheahjs/open-webui-fork/actions/runs/8574789343/job/23502369111 * Tagged Docker image: https://github.com/cheahjs/open-webui-fork/pkgs/container/open-webui-fork/200277278?tag=v0.1.118-dockertest This still isn't ideal, since Docker builds are triggered twice, and you end up with different Docker images for what is effectively the same underlying Git commit (`main`, `git-<hash>`, `<tag>` should all ideally point to the same image). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:27:16 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#7465
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?