github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 06:03:26 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[GH-ISSUE #22680] issue: has_public_read_access_grant is not defined in notes.py #74390

New Issue
Closed
opened 2026-05-13 07:07:57 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-05-13 07:07:57 -05:00
Owner
Copy Link

Originally created by @R-omk on GitHub (Mar 14, 2026).
Original GitHub issue: https://github.com/open-webui/open-webui/issues/22680

Check Existing Issues

  • I have searched for any existing and/or related issues.
  • I have searched for any existing and/or related discussions.
  • I have also searched in the CLOSED issues AND CLOSED discussions and found no related items (your issue might already be addressed on the development branch!).
  • I am using the latest version of Open WebUI.

Installation Method

Git Clone

Open WebUI Version

v0.8.10-slim

Ollama Version (if applicable)

No response

Operating System

Ubuntu 24.04

Browser (if applicable)

No response

Confirmation

  • I have read and followed all instructions in README.md.
  • I am using the latest version of both Open WebUI and Ollama.
  • I have included the browser console logs.
  • I have included the Docker container logs.
  • I have provided every relevant configuration, setting, and environment variable used in my setup.
  • I have clearly listed every relevant configuration, custom setting, environment variable, and command-line option that influences my setup (such as Docker Compose overrides, .env values, browser settings, authentication configurations, etc).
  • I have documented step-by-step reproduction instructions that are precise, sequential, and leave nothing to interpretation. My steps:
  • Start with the initial platform/version/OS and dependencies used,
  • Specify exact install/launch/configure commands,
  • List URLs visited, user input (incl. example values/emails/passwords if needed),
  • Describe all options and toggles enabled or changed,
  • Include any files or environmental changes,
  • Identify the expected and actual result at each stage,
  • Ensure any reasonably skilled user can follow and hit the same issue.

Expected Behavior

Users should be able to open public notes by clicking a direct share link. The endpoint should successfully check if a note is public and grant appropriate access.

Actual Behavior

When a user tries to open a public note via direct link, the server returns a 500 Internal Server Error:

File "/app/backend/open_webui/routers/notes.py", line 239, in get_note_by_id
    or has_public_read_access_grant(note.access_grants)
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NameError: name 'has_public_read_access_grant' is not defined

Users are redirected to the main page after the error.

Steps to Reproduce

  1. Create a new public note (as admin user)
  2. Copy the direct share link
  3. Open the link as a different user (non-admin)
  4. Observe 500 error in server logs and redirect to home page

Logs & Screenshots

index.ts:192 GET https://[HOST]/api/v1/notes/[UUID] 500 (Internal Server Error)

Additional Information

Root Cause

has_public_read_access_grant is used at line 239 but not imported:

# Line 239 - used but not imported
or has_public_read_access_grant(note.access_grants)

Current imports at lines 29-31:

from open_webui.utils.access_control import has_permission, filter_allowed_access_grants
from open_webui.models.access_grants import AccessGrants

Missing: has_public_read_access_grant import

When it was introduced

Date Commit Change
Feb 9, 2026 f7406ff576 ✅ Added import: has_public_read_access_grant
Feb 13, 2026 73776d54b89 (PR #21358) ✅ Added usage
Feb 23, 2026 176f9a7816 ("refac") ❌ Removed import, kept usage

Quick Fix

Add the missing import:

from open_webui.models.access_grants import (
    AccessGrants,
    has_public_read_access_grant
)
Originally created by @R-omk on GitHub (Mar 14, 2026). Original GitHub issue: https://github.com/open-webui/open-webui/issues/22680 ### Check Existing Issues - [x] I have searched for any existing and/or related issues. - [x] I have searched for any existing and/or related discussions. - [x] I have also searched in the CLOSED issues AND CLOSED discussions and found no related items (your issue might already be addressed on the development branch!). - [x] I am using the latest version of Open WebUI. ### Installation Method Git Clone ### Open WebUI Version v0.8.10-slim ### Ollama Version (if applicable) _No response_ ### Operating System Ubuntu 24.04 ### Browser (if applicable) _No response_ ### Confirmation - [x] I have read and followed all instructions in `README.md`. - [x] I am using the latest version of **both** Open WebUI and Ollama. - [x] I have included the browser console logs. - [x] I have included the Docker container logs. - [x] I have **provided every relevant configuration, setting, and environment variable used in my setup.** - [x] I have clearly **listed every relevant configuration, custom setting, environment variable, and command-line option that influences my setup** (such as Docker Compose overrides, .env values, browser settings, authentication configurations, etc). - [x] I have documented **step-by-step reproduction instructions that are precise, sequential, and leave nothing to interpretation**. My steps: - Start with the initial platform/version/OS and dependencies used, - Specify exact install/launch/configure commands, - List URLs visited, user input (incl. example values/emails/passwords if needed), - Describe all options and toggles enabled or changed, - Include any files or environmental changes, - Identify the expected and actual result at each stage, - Ensure any reasonably skilled user can follow and hit the same issue. ### Expected Behavior Users should be able to open public notes by clicking a direct share link. The endpoint should successfully check if a note is public and grant appropriate access. ### Actual Behavior When a user tries to open a public note via direct link, the server returns a **500 Internal Server Error**: ``` File "/app/backend/open_webui/routers/notes.py", line 239, in get_note_by_id or has_public_read_access_grant(note.access_grants) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ NameError: name 'has_public_read_access_grant' is not defined ``` Users are redirected to the main page after the error. ### Steps to Reproduce 1. Create a new **public** note (as admin user) 2. Copy the direct share link 3. Open the link as a **different user** (non-admin) 4. Observe 500 error in server logs and redirect to home page ### Logs & Screenshots index.ts:192 GET https://[HOST]/api/v1/notes/[UUID] 500 (Internal Server Error) ### Additional Information ### Root Cause `has_public_read_access_grant` is used at **line 239** but not imported: ```python # Line 239 - used but not imported or has_public_read_access_grant(note.access_grants) ``` Current imports at **lines 29-31**: ```python from open_webui.utils.access_control import has_permission, filter_allowed_access_grants from open_webui.models.access_grants import AccessGrants ``` **Missing**: `has_public_read_access_grant` import ### When it was introduced | Date | Commit | Change | |------|--------|--------| | Feb 9, 2026 | `f7406ff576` | ✅ Added import: `has_public_read_access_grant` | | Feb 13, 2026 | `73776d54b89` (PR #21358) | ✅ Added usage | | Feb 23, 2026 | `176f9a7816` ("refac") | ❌ **Removed** import, kept usage | ### Quick Fix Add the missing import: ```python from open_webui.models.access_grants import ( AccessGrants, has_public_read_access_grant ) ```
GiteaMirror added the bug label 2026-05-13 07:07:57 -05:00
GiteaMirror commented 2026-05-13 07:07:59 -05:00
Author
Owner
Copy Link

@tjbck commented on GitHub (Mar 15, 2026):

Addressed in dev!

<!-- gh-comment-id:4063983323 --> @tjbck commented on GitHub (Mar 15, 2026): Addressed in dev!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#74390
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?