[PR #1348] [MERGED] fix: enforce formatters on GitHub Actions #7438

New Issue

GiteaMirror · 2025-11-11T17:26:21-06:00

GiteaMirror commented

2025-11-11 17:26:21 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/1348
Author: @cheahjs
Created: 3/28/2024
Status: ✅ Merged
Merged: 3/29/2024
Merged by: @tjbck

Base: dev ← Head: fix/format-actions-enforce

📝 Commits (1)

f34fe49 fix: enforce formatters on GitHub Actions

📊 Changes

2 files changed (+5 additions, -0 deletions)

View changed files

📝 .github/workflows/format-backend.yaml (+2 -0)
📝 .github/workflows/format-build-frontend.yaml (+3 -0)

📄 Description

Pull Request Checklist

Description: Briefly describe the changes in this pull request.

Description

Workflows are not currently failing when the formatters produce a diff. This PR modifies the workflows to run a git diff after the formatters run to catch any unformatted code that was formatted.

As this hasn't been enforced in a while, this produces a massive diff that would need to be applied to actually merge the change in, and would likely result in merge conflicts for any in-flight PRs.

The frontend build is set to always run even if the format step fails, as it's useful to know if it's just a formatting issue, or if the PR doesn't build at all.

Example runs:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/1348 **Author:** [@cheahjs](https://github.com/cheahjs) **Created:** 3/28/2024 **Status:** ✅ Merged **Merged:** 3/29/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/format-actions-enforce` --- ### 📝 Commits (1) - [`f34fe49`](https://github.com/open-webui/open-webui/commit/f34fe49bdde4b44fe1d5c78857791acca4e2ad4b) fix: enforce formatters on GitHub Actions ### 📊 Changes **2 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/format-backend.yaml` (+2 -0) 📝 `.github/workflows/format-build-frontend.yaml` (+3 -0) </details> ### 📄 Description ## Pull Request Checklist - [x] **Description:** Briefly describe the changes in this pull request. --- ## Description Workflows are not currently failing when the formatters produce a diff. This PR modifies the workflows to run a `git diff` after the formatters run to catch any unformatted code that was formatted. As this hasn't been enforced in a while, this produces a massive diff that would need to be applied to actually merge the change in, and would likely result in merge conflicts for any in-flight PRs. The frontend build is set to always run even if the format step fails, as it's useful to know if it's just a formatting issue, or if the PR doesn't build at all. Example runs: * Python: https://github.com/cheahjs/open-webui-fork/actions/runs/8475065194/job/23222525498 * JS: https://github.com/cheahjs/open-webui-fork/actions/runs/8475065195/job/23222525488 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 17:26:21 -06:00

GiteaMirror closed this issue

2025-11-11 17:26:22 -06:00

GiteaMirror referenced this issue

2025-11-11 18:07:55 -06:00

[PR #7438] [CLOSED] Feature o1 thought #8854

Sign in to join this conversation.