[GH-ISSUE #21914] issue: Non-native tool calling broken. Else block misindented in process_chat_payload (middleware.py) #74217

Closed
opened 2026-05-13 06:54:57 -05:00 by GiteaMirror · 1 comment
Owner

Originally created by @ege-gungordu on GitHub (Feb 27, 2026).
Original GitHub issue: https://github.com/open-webui/open-webui/issues/21914

Check Existing Issues

  • I have searched for any existing and/or related issues.
  • I have searched for any existing and/or related discussions.
  • I have also searched in the CLOSED issues AND CLOSED discussions and found no related items (your issue might already be addressed on the development branch!).
  • I am using the latest version of Open WebUI.

Installation Method

Git Clone

Open WebUI Version

v0.8.5

Ollama Version (if applicable)

No response

Operating System

Ubuntu 22.04

Browser (if applicable)

No response

Confirmation

  • I have read and followed all instructions in README.md.
  • I am using the latest version of both Open WebUI and Ollama.
  • I have included the browser console logs.
  • I have included the Docker container logs.
  • I have provided every relevant configuration, setting, and environment variable used in my setup.
  • I have clearly listed every relevant configuration, custom setting, environment variable, and command-line option that influences my setup (such as Docker Compose overrides, .env values, browser settings, authentication configurations, etc).
  • I have documented step-by-step reproduction instructions that are precise, sequential, and leave nothing to interpretation. My steps:
  • Start with the initial platform/version/OS and dependencies used,
  • Specify exact install/launch/configure commands,
  • List URLs visited, user input (incl. example values/emails/passwords if needed),
  • Describe all options and toggles enabled or changed,
  • Include any files or environmental changes,
  • Identify the expected and actual result at each stage,
  • Ensure any reasonably skilled user can follow and hit the same issue.

Expected Behavior

When tools are present and function calling is set to default (non-native), chat_completion_tools_handler should be called to process the tools.

Actual Behavior

chat_completion_tools_handler is never called when tools are present. The else block is paired with the outer if tools_dict: check instead of the inner if function_calling == "native" check, so it only executes when tools_dict is empty.

Steps to Reproduce

  1. Run Open WebUI v0.8.5 via Docker (:main tag)
  2. Add any tool (e.g. an MCP tool server)
  3. Enable the tool in a chat and send a message that should trigger it (Make sure to keep tool calling method default)
  4. Observe the tool is never called

Logs & Screenshots

Not needed. clear indentation issue.

Additional Information

In backend/open_webui/utils/middleware.py, the else block for non-native tool calling is indented at the same level as if tools_dict:, making Python pair it with the outer check instead of the inner if function_calling == "native":

if tools_dict:
    if metadata.get("params", {}).get("function_calling") == "native":
        ...

else:  # ← paired with 'if tools_dict:', should be one level deeper
    ...chat_completion_tools_handler(...)
Originally created by @ege-gungordu on GitHub (Feb 27, 2026). Original GitHub issue: https://github.com/open-webui/open-webui/issues/21914 ### Check Existing Issues - [x] I have searched for any existing and/or related issues. - [x] I have searched for any existing and/or related discussions. - [x] I have also searched in the CLOSED issues AND CLOSED discussions and found no related items (your issue might already be addressed on the development branch!). - [x] I am using the latest version of Open WebUI. ### Installation Method Git Clone ### Open WebUI Version v0.8.5 ### Ollama Version (if applicable) _No response_ ### Operating System Ubuntu 22.04 ### Browser (if applicable) _No response_ ### Confirmation - [x] I have read and followed all instructions in `README.md`. - [x] I am using the latest version of **both** Open WebUI and Ollama. - [x] I have included the browser console logs. - [x] I have included the Docker container logs. - [x] I have **provided every relevant configuration, setting, and environment variable used in my setup.** - [x] I have clearly **listed every relevant configuration, custom setting, environment variable, and command-line option that influences my setup** (such as Docker Compose overrides, .env values, browser settings, authentication configurations, etc). - [x] I have documented **step-by-step reproduction instructions that are precise, sequential, and leave nothing to interpretation**. My steps: - Start with the initial platform/version/OS and dependencies used, - Specify exact install/launch/configure commands, - List URLs visited, user input (incl. example values/emails/passwords if needed), - Describe all options and toggles enabled or changed, - Include any files or environmental changes, - Identify the expected and actual result at each stage, - Ensure any reasonably skilled user can follow and hit the same issue. ### Expected Behavior When tools are present and function calling is set to default (non-native), chat_completion_tools_handler should be called to process the tools. ### Actual Behavior chat_completion_tools_handler is never called when tools are present. The else block is paired with the outer if tools_dict: check instead of the inner if function_calling == "native" check, so it only executes when tools_dict is empty. ### Steps to Reproduce 1. Run Open WebUI v0.8.5 via Docker (:main tag) 2. Add any tool (e.g. an MCP tool server) 3. Enable the tool in a chat and send a message that should trigger it (Make sure to keep tool calling method default) 4. Observe the tool is never called ### Logs & Screenshots Not needed. clear indentation issue. ### Additional Information In backend/open_webui/utils/middleware.py, the else block for non-native tool calling is indented at the same level as if tools_dict:, making Python pair it with the outer check instead of the inner if function_calling == "native": ```python if tools_dict: if metadata.get("params", {}).get("function_calling") == "native": ... else: # ← paired with 'if tools_dict:', should be one level deeper ...chat_completion_tools_handler(...) ```
GiteaMirror added the bug label 2026-05-13 06:54:57 -05:00
Author
Owner

@Classic298 commented on GitHub (Feb 27, 2026):

The seventh duplicate. Check for existing issues first!

Fixed in dev

<!-- gh-comment-id:3971390647 --> @Classic298 commented on GitHub (Feb 27, 2026): The seventh duplicate. Check for existing issues first! Fixed in dev
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#74217