[PR #968] [MERGED] fix: unnecesary double loop #7340

Closed
opened 2025-11-11 17:23:52 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/968
Author: @Carlos-err406
Created: 2/29/2024
Status: Merged
Merged: 2/29/2024
Merged by: @tjbck

Base: devHead: fix/double-loop


📝 Commits (1)

  • 30c94ff fix: unnecesary double loop

📊 Changes

1 file changed (+6 additions, -4 deletions)

View changed files

📝 src/lib/components/chat/Settings/Interface.svelte (+6 -4)

📄 Description

Pull Request Checklist

  • Description: Briefly describe the changes in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?

Description

fixes: issue #966

Changelog Entry

Added

  • dont filter for later iteration, just use a conditional when iterating

Fixed

  • optimized loop

Changed

/src/lib/components/chat/Settings/Interface.svelte

Removed

  • [List any removed features or files]

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/968 **Author:** [@Carlos-err406](https://github.com/Carlos-err406) **Created:** 2/29/2024 **Status:** ✅ Merged **Merged:** 2/29/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/double-loop` --- ### 📝 Commits (1) - [`30c94ff`](https://github.com/open-webui/open-webui/commit/30c94ff10f2a6f7fb6c649ea675d8b9c1dbcfd5a) fix: unnecesary double loop ### 📊 Changes **1 file changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/Interface.svelte` (+6 -4) </details> ### 📄 Description ## Pull Request Checklist - [x] **Description:** Briefly describe the changes in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? --- ## Description fixes: issue #966 --- ### Changelog Entry ### Added - dont filter for later iteration, just use a conditional when iterating ### Fixed - optimized loop - ### Changed /src/lib/components/chat/Settings/Interface.svelte ### Removed - [List any removed features or files] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:23:52 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#7340