github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-07 19:38:46 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #322] [MERGED] Add num_predict slider, fix settings not being sent to OpenAI endpoint & added more settings being sent #7052

New Issue
Closed
opened 2025-11-11 17:15:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 17:15:30 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/322
Author: @davidsyoung
Created: 12/29/2023
Status: ✅ Merged
Merged: 12/31/2023
Merged by: @tjbck

Base: main ← Head: fix-openai-settings

📝 Commits (5)

  • 431b710 Settings were being referenced incorrectly and as a result, no settings were being sent to openai endpoint. Added num_predict slider in advanced UI. Also added seed, stop and max_tokens (uses num_predict) being sent to openai endpoint.
  • b919ac7 Merge branch 'main' into fix-openai-settings
  • 7753851 Merge branch 'main' into fix-openai-settings
  • 0d6440f fix: num_predict default value should match ollama default
  • 1444001 fix: new params do not require legacy fallback

📊 Changes

5 files changed (+68 additions, -12 deletions)

View changed files

📝 src/lib/components/chat/Settings/Advanced.svelte (+47 -1)
📝 src/lib/components/chat/SettingsModal.svelte (+4 -2)
📝 src/routes/(app)/+page.svelte (+7 -4)
📝 src/routes/(app)/c/[id]/+page.svelte (+7 -4)
📝 src/routes/(app)/modelfiles/create/+page.svelte (+3 -1)

📄 Description

Hey! This is my first pull request, go easy on me!

Changes:

  • Added num_predict slider in advanced UI.
  • Settings were being referenced incorrectly in OpenAI chat/completions endpoint and as a result, no settings were being to the endpoint. Correctly added reference.
  • Added seed, stop and max_tokens (uses num_predict) parameters being sent to OpenAI endpoint.

Thank you once again!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/322 **Author:** [@davidsyoung](https://github.com/davidsyoung) **Created:** 12/29/2023 **Status:** ✅ Merged **Merged:** 12/31/2023 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `main` ← **Head:** `fix-openai-settings` --- ### 📝 Commits (5) - [`431b710`](https://github.com/open-webui/open-webui/commit/431b710e46b3a4fcd17a9d687ff9715a93e693e2) Settings were being referenced incorrectly and as a result, no settings were being sent to openai endpoint. Added num_predict slider in advanced UI. Also added seed, stop and max_tokens (uses num_predict) being sent to openai endpoint. - [`b919ac7`](https://github.com/open-webui/open-webui/commit/b919ac76afe2378434da606a4b94f1ba134681f2) Merge branch 'main' into fix-openai-settings - [`7753851`](https://github.com/open-webui/open-webui/commit/7753851e513c2a5e0575f8dee0f4fb1823c5a937) Merge branch 'main' into fix-openai-settings - [`0d6440f`](https://github.com/open-webui/open-webui/commit/0d6440f5c0162684776e1d5b5975d08b513ed2fb) fix: num_predict default value should match ollama default - [`1444001`](https://github.com/open-webui/open-webui/commit/14440014e5dc5359a59315ba4c86021337cea2c2) fix: new params do not require legacy fallback ### 📊 Changes **5 files changed** (+68 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/Advanced.svelte` (+47 -1) 📝 `src/lib/components/chat/SettingsModal.svelte` (+4 -2) 📝 `src/routes/(app)/+page.svelte` (+7 -4) 📝 `src/routes/(app)/c/[id]/+page.svelte` (+7 -4) 📝 `src/routes/(app)/modelfiles/create/+page.svelte` (+3 -1) </details> ### 📄 Description Hey! This is my first pull request, go easy on me! **Changes:** - Added num_predict slider in advanced UI. - Settings were being referenced incorrectly in OpenAI chat/completions endpoint and as a result, no settings were being to the endpoint. Correctly added reference. - Added seed, stop and max_tokens (uses num_predict) parameters being sent to OpenAI endpoint. Thank you once again! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 17:15:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#7052
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?