[PR #24288] perf: filter prompt list in SQL instead of N+1 has_access loop #66443

New Issue

GiteaMirror · 2026-05-06T12:48:32-05:00

GiteaMirror commented

2026-05-06 12:48:32 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24288
Author: @Classic298
Created: 5/1/2026
Status: 🔄 Open

Base: dev ← Head: perf/prompts-list-n1-fix

📝 Commits (1)

576fc39 perf(prompts): filter prompt list in SQL instead of N+1 has_access loop

📊 Changes

1 file changed (+47 additions, -16 deletions)

View changed files

📝 backend/open_webui/models/prompts.py (+47 -16)

📄 Description

get_prompts_by_user_id used to fetch every active prompt (with users + all access grants), then call AccessGrants.has_access() once per prompt that the user did not own. With 600+ prompts this issued ~600 extra round-trips per request and explained the multi-second delay reported in the GET /api/v1/prompts and /api/v1/prompts/tags endpoints for non-admin users.

Push the access check into a single SQL query via the existing AccessGrants.has_permission_filter (EXISTS subquery), so only accessible rows come back from the DB. Users and access grants for the surviving rows are still batch-fetched, no N+1 anywhere on this path.

Fixes https://github.com/open-webui/open-webui/discussions/24258

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24288 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/1/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `perf/prompts-list-n1-fix` --- ### 📝 Commits (1) - [`576fc39`](https://github.com/open-webui/open-webui/commit/576fc39e9930f1dd0e8a265a9ab0265c91ee7268) perf(prompts): filter prompt list in SQL instead of N+1 has_access loop ### 📊 Changes **1 file changed** (+47 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/prompts.py` (+47 -16) </details> ### 📄 Description get_prompts_by_user_id used to fetch every active prompt (with users + all access grants), then call AccessGrants.has_access() once per prompt that the user did not own. With 600+ prompts this issued ~600 extra round-trips per request and explained the multi-second delay reported in the GET /api/v1/prompts and /api/v1/prompts/tags endpoints for non-admin users. Push the access check into a single SQL query via the existing AccessGrants.has_permission_filter (EXISTS subquery), so only accessible rows come back from the DB. Users and access grants for the surviving rows are still batch-fetched, no N+1 anywhere on this path. Fixes https://github.com/open-webui/open-webui/discussions/24258  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 12:48:32 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#66443