github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-07 11:28:35 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #24049] [CLOSED] perf: skip redundant function row fetches when warming module cache on /api/models #66349

New Issue
Closed
opened 2026-05-06 12:40:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 12:40:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24049
Author: @jmleksan
Created: 4/23/2026
Status: ❌ Closed

Base: dev ← Head: perf/batch-functions-call

📝 Commits (1)

  • 20515e2 Enhance function module caching by allowing pre-fetched function rows to be passed, reducing redundant database queries.

📊 Changes

2 files changed (+27 additions, -13 deletions)

View changed files

📝 backend/open_webui/utils/models.py (+6 -5)
📝 backend/open_webui/utils/plugin.py (+21 -8)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. (N/A: internal backend optimization only; no user-facing API or env changes.)
  • Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. (None.)
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description. (Automated unit tests added; recommend quick manual smoke: load app, model list, actions/filters still work.)
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. (Optional function= argument; defaults preserve existing behavior.)
  • Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:

Changelog Entry

Description

  • When building the model list, Open WebUI batch-loads function rows with get_functions_by_ids, then warms the function module cache by calling get_function_module_from_cache once per function ID. Previously, each of those calls issued another get_function_by_id (primary-key SELECT) even though the row was already loaded. This change allows callers to pass the preloaded FunctionModel so the warmup path avoids redundant per-ID database round-trips. Behavior for callers that omit the new argument is unchanged.

Changed

  • get_function_module_from_cache(..., function: Optional[FunctionModel] = None): when function is provided with load_from_db=True, use the row’s content and skip Functions.get_function_by_id.
  • get_all_models warmup loop: pass function=function_row from functions_by_id into get_function_module_from_cache; comment updated to describe batch row reuse.

Additional Information

  • Motivation: Traces on GET /api/models showed many short, sequential PostgreSQL lookups on function by primary key after an IN (...) batch load. Removing the duplicate reads reduces latency and connection-pool pressure when multiple actions/filters are referenced.
  • Semantics: The preloaded row is the same snapshot as the batch query in that request. Call sites that do not pass function= still re-fetch from the DB as before.

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24049 **Author:** [@jmleksan](https://github.com/jmleksan) **Created:** 4/23/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `perf/batch-functions-call` --- ### 📝 Commits (1) - [`20515e2`](https://github.com/open-webui/open-webui/commit/20515e26c6b85b2e026caddfe4cbfeacb80a82e9) Enhance function module caching by allowing pre-fetched function rows to be passed, reducing redundant database queries. ### 📊 Changes **2 files changed** (+27 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/models.py` (+6 -5) 📝 `backend/open_webui/utils/plugin.py` (+21 -8) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. *(N/A: internal backend optimization only; no user-facing API or env changes.)* - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. *(None.)* - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. *(Automated unit tests added; recommend quick manual smoke: load app, model list, actions/filters still work.)* - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. *(Optional `function=` argument; defaults preserve existing behavior.)* - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: # Changelog Entry ### Description - When building the model list, Open WebUI batch-loads function rows with `get_functions_by_ids`, then warms the function module cache by calling `get_function_module_from_cache` once per function ID. Previously, each of those calls issued another `get_function_by_id` (primary-key `SELECT`) even though the row was already loaded. This change allows callers to pass the preloaded `FunctionModel` so the warmup path avoids redundant per-ID database round-trips. Behavior for callers that omit the new argument is unchanged. ### Changed - `get_function_module_from_cache(..., function: Optional[FunctionModel] = None)`: when `function` is provided with `load_from_db=True`, use the row’s `content` and skip `Functions.get_function_by_id`. - `get_all_models` warmup loop: pass `function=function_row` from `functions_by_id` into `get_function_module_from_cache`; comment updated to describe batch row reuse. --- ### Additional Information - **Motivation:** Traces on `GET /api/models` showed many short, sequential PostgreSQL lookups on `function` by primary key after an `IN (...)` batch load. Removing the duplicate reads reduces latency and connection-pool pressure when multiple actions/filters are referenced. - **Semantics:** The preloaded row is the same snapshot as the batch query in that request. Call sites that do not pass `function=` still re-fetch from the DB as before. ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 12:40:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#66349
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?