[PR #24009] [MERGED] fix: fix RichTextInput configuration #66328

Closed
opened 2026-05-06 12:37:37 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/24009
Author: @jmleksan
Created: 4/22/2026
Status: Merged
Merged: 4/24/2026
Merged by: @tjbck

Base: devHead: fix/rich-text-starterkit-fix


📝 Commits (1)

  • 8772403 feat: enhance RichTextInput configuration to prevent duplicate extensions when rich text is enabled

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 src/lib/components/common/RichTextInput.svelte (+11 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Not needed (no new env vars, APIs, or deployment changes).
  • Dependencies: No new or upgraded dependencies.
  • Testing: Manual validation completed (details below).
  • Agentic AI Code: This PR has gone through additional human review and manual testing.
  • Code review: Self-reviewed for scope and coding standards.
  • Design & Architecture: No new settings introduced; follows existing editor extension structure.
  • Git Hygiene: Atomic PR with one logical fix, based on dev.
  • Title Prefix: fix

Changelog Entry

Description

Fix duplicate TipTap extension registration in RichTextInput.svelte when richText mode is enabled.

StarterKit and ListKit/CodeBlockLowlight were both registering overlapping list/code block extensions, producing duplicate extension warnings and risking inconsistent editor behavior.

Changed

  • In src/lib/components/common/RichTextInput.svelte, StarterKit.configure(...) now conditionally disables overlapping extensions when richText is enabled:
    • codeBlock
    • bulletList
    • orderedList
    • listItem
    • listKeymap

This ensures ListKit and CodeBlockLowlight are the single source of truth for those nodes/commands in rich text mode.

Fixed

  • TipTap warning about duplicate extension names:
    • codeBlock
    • bulletList
    • listItem
    • listKeymap
    • orderedList
  • Potential rich text editor conflicts from duplicate extension ownership.

Additional Information

  • Manual testing
    • Confirm duplicate extension warning is gone.
    • Validate list features: bullet list, ordered list, nesting/indent/outdent.
    • Validate code block insert/edit behavior.
    • Verify no regressions in normal rich text editing interactions.

Screenshots or Videos

image

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/24009 **Author:** [@jmleksan](https://github.com/jmleksan) **Created:** 4/22/2026 **Status:** ✅ Merged **Merged:** 4/24/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/rich-text-starterkit-fix` --- ### 📝 Commits (1) - [`8772403`](https://github.com/open-webui/open-webui/commit/8772403a72459da0c879baf964cd8a14cd4bd27f) feat: enhance RichTextInput configuration to prevent duplicate extensions when rich text is enabled ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/common/RichTextInput.svelte` (+11 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Not needed (no new env vars, APIs, or deployment changes). - [x] **Dependencies:** No new or upgraded dependencies. - [x] **Testing:** Manual validation completed (details below). - [x] **Agentic AI Code:** This PR has gone through additional human review and manual testing. - [x] **Code review:** Self-reviewed for scope and coding standards. - [x] **Design & Architecture:** No new settings introduced; follows existing editor extension structure. - [x] **Git Hygiene:** Atomic PR with one logical fix, based on `dev`. - [x] **Title Prefix:** `fix` # Changelog Entry ### Description Fix duplicate TipTap extension registration in `RichTextInput.svelte` when `richText` mode is enabled. `StarterKit` and `ListKit`/`CodeBlockLowlight` were both registering overlapping list/code block extensions, producing duplicate extension warnings and risking inconsistent editor behavior. ### Changed - In `src/lib/components/common/RichTextInput.svelte`, `StarterKit.configure(...)` now conditionally disables overlapping extensions when `richText` is enabled: - `codeBlock` - `bulletList` - `orderedList` - `listItem` - `listKeymap` This ensures `ListKit` and `CodeBlockLowlight` are the single source of truth for those nodes/commands in rich text mode. ### Fixed - TipTap warning about duplicate extension names: - `codeBlock` - `bulletList` - `listItem` - `listKeymap` - `orderedList` - Potential rich text editor conflicts from duplicate extension ownership. --- ### Additional Information - **Manual testing** - Confirm duplicate extension warning is gone. - Validate list features: bullet list, ordered list, nesting/indent/outdent. - Validate code block insert/edit behavior. - Verify no regressions in normal rich text editing interactions. ### Screenshots or Videos <img width="997" height="29" alt="image" src="https://github.com/user-attachments/assets/fe4cfaa3-3c4f-44cc-825e-878dcaac804e" /> ### Contributor License Agreement - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 12:37:37 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#66328