github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #23991] [CLOSED] fix(windows): prevent glob expansion of * in start_windows.bat #66324

New Issue
Closed
opened 2026-05-06 12:37:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 12:37:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23991
Author: @flobo3
Created: 4/22/2026
Status: ❌ Closed

Base: dev ← Head: fix/windows-start-bat-glob

📝 Commits (10+)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 backend/start_windows.bat (+2 -2)

📄 Description

Problem

start_windows.bat fails on Windows when FORWARDED_ALLOW_IPS is unset (the default). The script sets it to *:

SET "FORWARDED_ALLOW_IPS=*"

Then passes it to uvicorn via CLI flag:

uvicorn ... --forwarded-allow-ips "%FORWARDED_ALLOW_IPS%" ...

CMD expands %FORWARDED_ALLOW_IPS% before the quotes take effect, causing * to be glob-expanded to filenames in the current directory:

Error: Got unexpected extra arguments (dev.sh open_webui requirements-min.txt ...)

Fix

Remove --forwarded-allow-ips from the uvicorn CLI arguments entirely. Uvicorn already reads the FORWARDED_ALLOW_IPS environment variable automatically when the CLI flag is not provided. The env var is already set correctly by the SET command on line 27 and does not suffer from glob expansion since it's never passed through CMD argument parsing.

Testing: Verified that SET "FORWARDED_ALLOW_IPS=*" sets the env var correctly and uvicorn picks it up from the environment without the CLI flag.

Fixes #23989

CLAs:

  • I confirm that my pull request can be merged under the MIT license

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23991 **Author:** [@flobo3](https://github.com/flobo3) **Created:** 4/22/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/windows-start-bat-glob` --- ### 📝 Commits (10+) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`6adde20`](https://github.com/open-webui/open-webui/commit/6adde203cd292a9e3af9c64a2ae36b603fed096a) Merge pull request #20394 from open-webui/dev - [`f9b0534`](https://github.com/open-webui/open-webui/commit/f9b0534e0c442631d1cb7205169588b9b6204179) Merge pull request #20522 from open-webui/dev ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/start_windows.bat` (+2 -2) </details> ### 📄 Description ## Problem `start_windows.bat` fails on Windows when `FORWARDED_ALLOW_IPS` is unset (the default). The script sets it to `*`: ```bat SET "FORWARDED_ALLOW_IPS=*" ``` Then passes it to uvicorn via CLI flag: ```bat uvicorn ... --forwarded-allow-ips "%FORWARDED_ALLOW_IPS%" ... ``` CMD expands `%FORWARDED_ALLOW_IPS%` before the quotes take effect, causing `*` to be glob-expanded to filenames in the current directory: ``` Error: Got unexpected extra arguments (dev.sh open_webui requirements-min.txt ...) ``` ## Fix Remove `--forwarded-allow-ips` from the uvicorn CLI arguments entirely. Uvicorn already reads the `FORWARDED_ALLOW_IPS` environment variable automatically when the CLI flag is not provided. The env var is already set correctly by the `SET` command on line 27 and does not suffer from glob expansion since it's never passed through CMD argument parsing. **Testing:** Verified that `SET "FORWARDED_ALLOW_IPS=*"` sets the env var correctly and uvicorn picks it up from the environment without the CLI flag. Fixes #23989 --- **CLAs:** - [x] I confirm that my pull request can be merged under the MIT license --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 12:37:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#66324
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?