d7aa9fa perf: avoid redundant knowledge re-fetch in update_knowledge_access_by_id
📊 Changes
1 file changed (+4 additions, -2 deletions)
View changed files
📝backend/open_webui/routers/knowledge.py (+4 -2)
📄 Description
After set_access_grants, the handler was reloading the same knowledge record via get_knowledge_by_id, which triggers an extra SELECT plus a nested fetch of access grants. set_access_grants already returns the newly-written grants and the local knowledge object is otherwise unchanged, so update it in place and reuse it for the response.
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/23799
**Author:** [@Classic298](https://github.com/Classic298)
**Created:** 4/16/2026
**Status:** ✅ Merged
**Merged:** 4/17/2026
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `claude/fix-knowledge-refetch-ufcPX`
---
### 📝 Commits (1)
- [`d7aa9fa`](https://github.com/open-webui/open-webui/commit/d7aa9faa82ccdda7fe528ba980ff443606d7542d) perf: avoid redundant knowledge re-fetch in update_knowledge_access_by_id
### 📊 Changes
**1 file changed** (+4 additions, -2 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/routers/knowledge.py` (+4 -2)
</details>
### 📄 Description
After set_access_grants, the handler was reloading the same knowledge record via get_knowledge_by_id, which triggers an extra SELECT plus a nested fetch of access grants. set_access_grants already returns the newly-written grants and the local knowledge object is otherwise unchanged, so update it in place and reuse it for the response.
### Contributor License Agreement
<!--
🚨 DO NOT DELETE THE TEXT BELOW 🚨
Keep the "Contributor License Agreement" confirmation text intact.
Deleting it will trigger the CLA-Bot to INVALIDATE your PR.
Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA.
-->
- [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms.
> [!NOTE]
> Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/23799
Author: @Classic298
Created: 4/16/2026
Status: ✅ Merged
Merged: 4/17/2026
Merged by: @tjbck
Base:
dev← Head:claude/fix-knowledge-refetch-ufcPX📝 Commits (1)
d7aa9faperf: avoid redundant knowledge re-fetch in update_knowledge_access_by_id📊 Changes
1 file changed (+4 additions, -2 deletions)
View changed files
📝
backend/open_webui/routers/knowledge.py(+4 -2)📄 Description
After set_access_grants, the handler was reloading the same knowledge record via get_knowledge_by_id, which triggers an extra SELECT plus a nested fetch of access grants. set_access_grants already returns the newly-written grants and the local knowledge object is otherwise unchanged, so update it in place and reuse it for the response.
Contributor License Agreement
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.