[PR #23797] [CLOSED] perf(chats): avoid redundant fetch in get_chat_by_share_id #66230

New Issue

GiteaMirror · 2026-05-06T12:28:47-05:00

GiteaMirror commented

2026-05-06 12:28:47 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23797
Author: @Classic298
Created: 4/16/2026
Status: ❌ Closed

Base: dev ← Head: claude/optimize-chat-share-id-9ym0Z

📝 Commits (1)

a963bea perf(chats): avoid redundant fetch in get_chat_by_share_id

📊 Changes

1 file changed (+8 additions, -4 deletions)

View changed files

📝 backend/open_webui/models/chats.py (+8 -4)

📄 Description

get_chat_by_share_id already loads the Chat row via share_id lookup, then discarded it and re-fetched through get_chat_by_id. Drop the second query and return the row we already have, preserving the null-byte sanitization behavior inline.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23797 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/16/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `claude/optimize-chat-share-id-9ym0Z` --- ### 📝 Commits (1) - [`a963bea`](https://github.com/open-webui/open-webui/commit/a963bea8f555921123fdf12e7663fd8546a19234) perf(chats): avoid redundant fetch in get_chat_by_share_id ### 📊 Changes **1 file changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/chats.py` (+8 -4) </details> ### 📄 Description get_chat_by_share_id already loads the Chat row via share_id lookup, then discarded it and re-fetched through get_chat_by_id. Drop the second query and return the row we already have, preserving the null-byte sanitization behavior inline. ### Contributor License Agreement  - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 12:28:47 -05:00

GiteaMirror closed this issue

2026-05-06 12:28:56 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#66230