[PR #23747] [CLOSED] fix: add missing db parameter to filter_allowed_access_grants in update_note_access_by_id #66208

New Issue

GiteaMirror · 2026-05-06T12:26:11-05:00

GiteaMirror commented

2026-05-06 12:26:11 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23747
Author: @Ricardo-M-L
Created: 4/15/2026
Status: ❌ Closed

Base: dev ← Head: fix/notes-missing-db-param-v2

📝 Commits (1)

59e6392 fix: add missing db parameter to filter_allowed_access_grants in update_note_access_by_id

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 backend/open_webui/routers/notes.py (+1 -0)

📄 Description

Description

In update_note_access_by_id(), the call to filter_allowed_access_grants() at line 394 is missing the db=db parameter. The same function is called correctly with db=db in create_new_note() (line 224) and update_note_by_id() (line 336).

Without db, the function falls back to None and may fail to validate group-based access grants that require database lookups.

Changelog

Fixed: Missing db parameter in filter_allowed_access_grants() call within update_note_access_by_id()

Breaking Changes

None

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23747 **Author:** [@Ricardo-M-L](https://github.com/Ricardo-M-L) **Created:** 4/15/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/notes-missing-db-param-v2` --- ### 📝 Commits (1) - [`59e6392`](https://github.com/open-webui/open-webui/commit/59e63926adb34b6bec5d6e891a7dce8cb1cf1fb4) fix: add missing db parameter to filter_allowed_access_grants in update_note_access_by_id ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/notes.py` (+1 -0) </details> ### 📄 Description ## Description In `update_note_access_by_id()`, the call to `filter_allowed_access_grants()` at line 394 is missing the `db=db` parameter. The same function is called correctly with `db=db` in `create_new_note()` (line 224) and `update_note_by_id()` (line 336). Without `db`, the function falls back to `None` and may fail to validate group-based access grants that require database lookups. ### Changelog - **Fixed**: Missing `db` parameter in `filter_allowed_access_grants()` call within `update_note_access_by_id()` ### Breaking Changes - None ### Contributor License Agreement - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-06 12:26:11 -05:00

GiteaMirror closed this issue

2026-05-06 12:26:15 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#66208